openfoam: ignore extended number of faces (fixes paraview#14235)

• occurs with foam-extend globalFaceZone, in which the faces list is longer than owner/neighbour lists (with the extra faces belonging to the globalFaceZone).

  Remedy by simply resetting the known NumFaces to be consistent with owner/neighbour information. The excess faces will simply be dragged along without being addressed. This is a minor memory overhead (versus truncating the face list), but only affects cases with globalFaceZone and still allows some possibility to handling in the future if desired. Adjustment consistent with CreateCellFaces() private method.

assigned to @mwestphal

Warnings:

• please consider adding a changelog entry in a file ending with .md in Documentation/release/dev.

The warnings do not need to be fixed, but it is recommended to do so.

unassigned @mwestphal

cross-ref: paraview/paraview#14235 (closed)

@sergeylesnik - now staged, awaiting merge from @charles.gueunet or @mwestphal

If you are feeling ambitious, could be useful to add the mixer GGI test case to the VTK testdata.

Indeed, that would be better to add a test for this if possible.

resolved all threads

resolved all threads

@sergeylesnik - any tests coming? Seeing that it's be on the list for about 8-9 years, would be nice to get it over the line now.

@olesen I saw it more like "some more weeks won't make a difference after 8-9 years". I'll take care of it the next days.

Wasn't sure about the proper workflow. So I forked @olesen topic "openfoam-ggi-interface" but had to make an own branch in order to use git gitlab-push for the data upload. Everything works but is now located here: https://gitlab.kitware.com/sergeylesnik/vtk/-/tree/openfoam-ggi-test?ref_type=heads. How should we proceed @mwestphal?

added 1 commit

• 4cc5f213 - openfoam: add a test for decomposed GGI / global face zone

Compare with previous version

Errors:

• commit 4cc5f213 is not allowed because the following files are not formatted according to the 'clang-format' check: IO/Parallel/Testing/Cxx/TestPOpenFOAMReaderGlobalFaceZone.cxx. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.

Warnings:

• please consider adding a changelog entry in a file ending with .md in Documentation/release/dev.

The warnings do not need to be fixed, but it is recommended to do so.

Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

Do: reformat

This topic has been reformatted and pushed; please fetch from the source repository and reset your local branch to continue with further development on the reformatted commits.

added 1 commit

• 93a57daa - openfoam: add a test for decomposed GGI / global face zone

Compare with previous version

Warnings:

• please consider adding a changelog entry in a file ending with .md in Documentation/release/dev.

The warnings do not need to be fixed, but it is recommended to do so.

Do: test

Perfect

+2