vtkConstrainedPointHandleRepresentation - incorrectly checking this->CursorShape
requested to merge paulharris/vtk:paulharris-master-fix-vtkConstrainedPointHandleRepresentation into master
The destructor calls: this->SetActiveCursorShape(nullptr);
In ::SetActiveCursorShape() there seems to be a typo:
it checks if (this->CursorShape),
not if (this->ActiveCursorShape) which is what this method is about.
gcc highlighted with a secondary warning: 'this' pointer is null
As the method is called during the destructor, and then on line 230, 'this' is used as a parameter:
this->ActiveCursorShape->Register(this);