Remove usage of `vtkMath::<random>`
This API was discovered to produce different results based on the platform in #18212. These methods have also been long-commented (since 2016) to not be used anymore. !7985 adds deprecations for these, but will just end up generating a lot of noise. This issue tracks actual removal of the calls from the VTK codebase. Please check off the class and link to the MR (leave a comment if you cannot edit it).
"Live" VTK code:
-
Common/DataModel/vtkPolygon.cxx -
Common/DataModel/vtkPolyhedron.cxx -
Common/Math/vtkPolynomialSolversUnivariate.cxx -
Examples/iOS/Surfaces/Classes/MyGLKViewController.mm -
Filters/Core/vtkMaskPoints.cxx -
Filters/Core/vtkVoronoi2D.cxx -
Filters/General/vtkBrownianPoints.cxx -
Filters/General/vtkRandomAttributeGenerator.cxx -
Filters/Hybrid/vtkTemporalFractal.cxx -
Filters/Modeling/vtkSelectEnclosedPoints.cxx -
Filters/Parallel/vtkCutMaterial.cxx -
Filters/Parallel/vtkPieceScalars.cxx -
Filters/Parallel/vtkProcessIdScalars.cxx -
Filters/Points/vtkBoundedPointSource.cxx -
Filters/Sources/vtkPointSource.cxx -
IO/Geometry/vtkCGMWriter.cxx -
Imaging/Sources/vtkImageNoiseSource.cxx -
Infovis/Core/vtkRandomGraphSource.cxx -
Infovis/Layout/vtkAssignCoordinates.cxx -
Infovis/Layout/vtkAttributeClustering2DLayoutStrategy.cxx -
Infovis/Layout/vtkClustering2DLayoutStrategy.cxx -
Infovis/Layout/vtkCommunity2DLayoutStrategy.cxx -
Infovis/Layout/vtkConstrained2DLayoutStrategy.cxx -
Infovis/Layout/vtkFast2DLayoutStrategy.cxx -
Infovis/Layout/vtkForceDirectedLayoutStrategy.cxx -
Infovis/Layout/vtkIncrementalForceLayout.cxx -
Infovis/Layout/vtkRandomLayoutStrategy.cxx -
Infovis/Layout/vtkSimple2DLayoutStrategy.cxx -
Rendering/Core/vtkCellCenterDepthSort.cxx -
Rendering/Label/vtkLabelHierarchy.cxx
Testing code:
-
Common/Core/Testing/Cxx/TestMinimalStandardRandomSequence.cxx -
Common/Core/Testing/Cxx/TestSortDataArray.cxx -
Common/Core/Testing/Cxx/TestTimePointUtility.cxx -
Common/Core/Testing/Cxx/TestVariantArray.cxx -
Common/Core/Testing/Cxx/UnitTestMath.cxx -
Common/DataModel/Testing/Cxx/TestComputeBoundingSphere.cxx -
Common/DataModel/Testing/Cxx/TestSortFieldData.cxx -
Common/DataModel/Testing/Cxx/TestTable.cxx -
Common/DataModel/Testing/Cxx/TimePointLocators.cxx -
Common/DataModel/Testing/Cxx/UnitTestCells.cxx -
Common/Misc/Testing/Cxx/UnitTestFunctionParser.cxx -
Filters/Core/Testing/Cxx/TestAppendDataSets.cxx -
Filters/Core/Testing/Cxx/TestAppendFilter.cxx -
Filters/Core/Testing/Cxx/TestProbeFilterImageInput.cxx -
Filters/Core/Testing/Python/TestProbeFilterImageInput.py -
Filters/FlowPaths/Testing/Cxx/TestBSPTree.cxx -
Filters/General/Testing/Cxx/BoxClipTriangulate.cxx -
Filters/General/Testing/Cxx/TestCellValidator.cxx -
Filters/General/Testing/Cxx/TestMergeCells.cxx -
Filters/General/Testing/Cxx/TestRectilinearGridToPointSet.cxx -
Filters/General/Testing/Cxx/TestUncertaintyTubeFilter.cxx -
Filters/General/Testing/Cxx/UnitTestMultiThreshold.cxx -
Filters/ParallelStatistics/Testing/Cxx/TestRandomPContingencyStatisticsMPI.cxx -
Filters/ParallelStatistics/Testing/Cxx/TestRandomPKMeansStatisticsMPI.cxx -
Filters/ParallelStatistics/Testing/Cxx/TestRandomPMomentStatisticsMPI.cxx -
Filters/ParallelStatistics/Testing/Cxx/TestRandomPOrderStatisticsMPI.cxx -
Filters/Statistics/Testing/Cxx/TestCorrelativeStatistics.cxx -
Filters/Statistics/Testing/Cxx/TestDescriptiveStatistics.cxx -
Filters/Statistics/Testing/Cxx/TestKMeansStatistics.cxx -
Infovis/BoostGraphAlgorithms/Testing/Cxx/TestBoostAdapter.cxx -
Infovis/Layout/Testing/Cxx/TestIncrementalForceLayout.cxx -
Interaction/Widgets/Testing/Cxx/TestDistanceWidget.cxx -
Interaction/Widgets/Testing/Cxx/TestDistanceWidget3D.cxx -
Parallel/MPI/Testing/Cxx/ExerciseMultiProcessController.cxx -
Rendering/Annotation/Testing/Cxx/TestBarChartActor.cxx -
Rendering/Annotation/Testing/Cxx/TestPieChartActor.cxx -
Rendering/Annotation/Testing/Cxx/TestSpiderPlotActor.cxx -
Rendering/Label/Testing/Cxx/TestLabelPlacementMapper2D.cxx -
Rendering/Label/Testing/Cxx/TestLabelPlacementMapperCoincidentPoints.cxx -
Rendering/Label/Testing/Cxx/TestLabelPlacer2D.cxx -
Rendering/Label/Testing/Cxx/TestLabelPlacerCoincidentPoints.cxx -
Rendering/RayTracing/Testing/Cxx/TestOSPRayUnstructuredVolumeMapperMixedCells.cxx
Edited by Ben Boeckel