Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • VTK VTK
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 830
    • Issues 830
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 232
    • Merge requests 232
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • VTKVTK
  • VTKVTK
  • Issues
  • #18178
Closed
Open
Issue created Apr 19, 2021 by bartoli@bartoli

Request : change public API methods taking std:string

Following the discussion at https://discourse.vtk.org/t/crash-in-tolowercase/5247/6, public API methods that take references to std::string as arguments can crash if VTK is not built with the same toolset as the one used to build an application linking to VTK. Here, it was between two gcc (and libstdc++) versions. I also encountered the same kind of issue on windows for some other projects, where a software and a library were not built using the same Visual Studio compilers, and crashed too. Those arguments should be replaced by char* buffers, or a vtk type used to handle strings, and not use a template type that might not have the same definition for both llib and application compiler The problematic method here was vtkNamedColors::setColor(). I don't know how widespread std::string arguments are, but i guess it is used in other places

Edited Apr 19, 2021 by bartoli
Assignee
Assign to
Time tracking