Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • VTK VTK
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 833
    • Issues 833
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 240
    • Merge requests 240
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • VTKVTK
  • VTKVTK
  • Issues
  • #17193
Closed
Open
Issue created Dec 04, 2017 by Taylor Braun-Jones@nocnokneoContributor

CMake IMPORTED module targets are incomplete

The imported targets for each VTK module are missing information like include directories, compile definitions, etc. For example, currently for vtkCommonMath there is the following in VTKTargets*.cmake:

# Create imported target vtkCommonMath
add_library(vtkCommonMath SHARED IMPORTED)

set_target_properties(vtkCommonMath PROPERTIES
  INTERFACE_COMPILE_FEATURES "cxx_nullptr"
  INTERFACE_LINK_LIBRARIES "vtkCommonCore"
)

# Import target "vtkCommonMath" for configuration "RelWithDebInfo"
set_property(TARGET vtkCommonMath APPEND PROPERTY IMPORTED_CONFIGURATIONS RELWITHDEBINFO)
set_target_properties(vtkCommonMath PROPERTIES
  IMPORTED_IMPLIB_RELWITHDEBINFO "${_IMPORT_PREFIX}/lib/vtkCommonMath-8.0.lib"
  IMPORTED_LOCATION_RELWITHDEBINFO "${_IMPORT_PREFIX}/bin/vtkCommonMath-8.0.dll"
  )

list(APPEND _IMPORT_CHECK_TARGETS vtkCommonMath )
list(APPEND _IMPORT_CHECK_FILES_FOR_vtkCommonMath "${_IMPORT_PREFIX}/lib/vtkCommonMath-8.0.lib" "${_IMPORT_PREFIX}/bin/vtkCommonMath-8.0.dll" )

What's missing is something like:

set_target_properties(vtkCommonMath PROPERTIES
  INTERFACE_INCLUDE_DIRECTORIES "${vtkCommonMath_INCLUDE_DIRS}"
)
set_target_properties(vtkCommonMath PROPERTIES
  INTERFACE_COMPILE_DEFINITIONS "${vtkCommonMath_DEFINITIONS}"
)
Assignee
Assign to
Time tracking