conditional addition of VTKm_OPENLGL_INCLUDE_DIRS
On a system that has no opengl or mesa and with rendering enabled (such as docker container), vtkm fails to configure when adding target_include_directories for the rendering library. I believe this happens because cmake determines that the variable VTKm_OPENGL_INCLUDE_DIRECTORIES is dependent on OPENGL_INCLUDE_DIRS( which is NOTFOUND). This causes cmake to raise an error even when VTKm_OPENGL_INCLUDE_DIRECTORIES is set to "".
This fixes the issue.
Merge request reports
Activity
@mclarsen Thanks for fixing this.
Can you please revise your commit and add the contents of you MR message to the commit. That way we have the why on this change in the git history.
added 1 commit
- 8105fa0e - conditional addition of VTKm_OPENLGL_INCLUDE_DIRS
added 1 commit
- 7b2595f3 - On a system that has no opengl or mesa and with rendering enabled (such as docke…
Errors:
- commit 7b2595f3 has an invalid commit subject; the first line must be no longer than 120 characters.
Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.
added 1 commit
- 013ff1ba - On a system that has no opengl or mesa and with rendering enabled (such as docke…
mentioned in commit ab76f816