Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • VTK-m VTK-m
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 194
    • Issues 194
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 36
    • Merge requests 36
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • VTK
  • VTK-mVTK-m
  • Merge requests
  • !581

Refactor vtk-m symbol visibility macros to be more consistent.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Robert Maynard requested to merge robertmaynard/vtk-m:refactor_vtkm_symbol_vis_controls into master Oct 13, 2016
  • Overview 18
  • Commits 1
  • Pipelines 4
  • Changes 32

There really isn't any reason to use the CMake generated export macro header as it can easily be written in a cross platform way inside VTK-m.

Secondly instead of labeling each method that needs to have visibility we can label entire classes.

Lastly the CMake generated export macro functionality would break if we every tried to generate export macros from the cont or exec directory, as those defines already exist to label device/host code.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: refactor_vtkm_symbol_vis_controls