Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • VTK-m VTK-m
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 210
    • Issues 210
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 37
    • Merge requests 37
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • VTKVTK
  • VTK-mVTK-m
  • Merge requests
  • !349

You can know specify the default set of types worklets in vtkm support.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Robert Maynard requested to merge robertmaynard/vtk-m:allow_control_over_default_field_types into master Mar 04, 2016
  • Overview 4
  • Commits 1
  • Pipelines 0
  • Changes 6

When writing integration code between vtk-m and other libraries you generally have a subset of data-types that you want to run worklets on.

The problem arises that general purpose field worklets generally define that they can run on 'all' datatypes, but as the integrator want to limit 'all' to a smaller subset.

If you only use vtkm::cont::ArrayHandle this is never a problem, but if you ever use vtkm::cont::DynamicArrayHandle this becomes an issue as you auto generate code paths that are never reachable ( and will cost you time and space ).

The solution was to allow integrators to define what the default tag is for FieldIn, FieldOut, etc.

Results: A single worklet with three dynamic Fields will generate a library of size 2.2MB when use the default of ListTagAll. If you change that tag to TypeListTagField the result is 800KB.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: allow_control_over_default_field_types