Making Color Bar Annonations non-Virtual

Both ColorBar and ColorLegend are never used polymorphically. Their Render() don't need to be virtual. One of them didn't even have a virtual destructor either.

requested review from @kmorel

Errors:

• commit a2f71e67 is not allowed because the following files are not formatted according to the 'clang-format' check: vtkm/rendering/ColorLegendAnnotation.cxx, vtkm/rendering/ColorLegendAnnotation.h. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.

Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

Do: reformat

This topic has been reformatted and pushed; please fetch from the source repository and reset your local branch to continue with further development on the reformatted commits.

added 1 commit

• 10bcf618 - non-virtual color table annotations

Compare with previous version

I don't have a strong opinion about virtual or not.

added 1 commit

• 85b4b18f - properly call make_unique

Compare with previous version

resolved all threads

added 1 commit

• c8caecfe - try to supress warning on windows

Compare with previous version

@vbolea

Is there anything wrong with the hip test platform?

https://gitlab.kitware.com/ollielo/vtk-m/-/jobs/8318168

@kmorel pipeline fixed. Please review.

resolved all threads

+1

Do: merge

mentioned in commit 75d0dd9b

merged