Mark ArrayHandle constructors taking buffers, as explicit (!3076) · Merge requests · VTK / VTK-m

Sujin Philip requested to merge sujin.philip/vtk-m:arrayhandle-explicit-constructors into master Jun 05, 2023

This resolves a compiler ambiguity I hit during development. In my case, I created an ArrayHandleDecorator with one of the arrays being an ArrayHandleTransform. The ambiguity occurs in function DecoratorStorageTraits<...>::BuffersToArray[1], here an ArrayHandleTransform is constructed using buffers (std::vector<vtkm::cont::internal::Buffer>)

This constructor is not defined for ArrayHandleTransform, but it's defined for its superclass (vtkm::cont::ArrayHandle)[2]. ArrayHandleTransform does have a non-explicit constructor that takes the array to be transformed and the transform-functor as parameters, where the later has a default value[3]. This produces the following ambiguous options for the compiler:

Create an instance of the ArrayHandle that is to be transformed, using the buffers[2], and call the ArrayHandleTransform constructor with this array with the defaulted functor parameter [3].
Create the superclass instance using the buffer[2] and call the ArrayHandleTransform constructor that takes the superclass[4].

In this situation, option 2 is the correct choice.

The ambiguity is resolved by marking the constructors that take buffers as explicit. These constructors are also added for the derived classess via the VTK_M_ARRAY_HANDLE_SUBCLASS_IMPL macro.

Edited Jun 13, 2023 by Sujin Philip

Mark ArrayHandle constructors taking buffers, as explicit

Merge request reports