Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • VTK-m VTK-m
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 206
    • Issues 206
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 41
    • Merge requests 41
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Terraform modules
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

Admin message

A Gitlab update will be applied on June 5th , between 6PM - 7PM EDT (UTC-04:00). This site may have intermittent delays during that time.

  • VTKVTK
  • VTK-mVTK-m
  • Merge requests
  • !3022

Make divide by volume in particle density estimate a little safer

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Kenneth Moreland requested to merge kmorel/vtk-m:safer-divide-by-volume into master Mar 21, 2023
  • Overview 3
  • Commits 1
  • Pipelines 1
  • Changes 1

While going through the VTK-m code to identify where a cast-and-call was happening against VTKM_DEFAULT_TYPE_LIST, I ran into a subtle case in ParticleDensityBase that was calling a worklet with an UnknownArrayHandle. This works OK, but was probably compiling for unnecessary types (for example, vectors). Changed the field resolution to be more intentional.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: safer-divide-by-volume