Skip to content
Snippets Groups Projects

Add abort execution feature

Merged Add abort execution feature
sujin.philip/vtk-m:vtkm-abort into master
2 unresolved threads
Merged Sujin Philip requested to merge sujin.philip/vtk-m:vtkm-abort into master
2 unresolved threads

Initial changes to add support for aborting execution.

backport: release

Merge request reports

Merge request pipeline #317752 failed

Stage: build
Stage: test
Stage: external

Merge request pipeline failed for 42c6959b

Approval is optional

Merged by Kitware RobotKitware Robot 2 years ago (Feb 13, 2023 5:41pm UTC)

Merge details

  • Changes merged into with d05afa72.
  • Did not delete the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Kenneth Moreland
  • Kenneth Moreland
  • Kenneth Moreland
  • Kenneth Moreland
  • Kenneth Moreland
  • Sujin Philip resolved all threads

    resolved all threads

  • Sujin Philip added 1 commit

    added 1 commit

    Compare with previous version

  • Kitware Robot
    Kitware Robot @kwrobot ·
    Owner

    Errors:

    • commit d987ea3c is not allowed because the following files are not formatted according to the 'clang-format' check: vtkm/cont/RuntimeDeviceTracker.cxx, vtkm/cont/TryExecute.cxx. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.

    Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

  • Kitware Robot
    Kitware Robot @kwrobot ·
    Owner

    Errors:

    • commit d987ea3c is not allowed because the following files are not formatted according to the 'clang-format' check: vtkm/cont/RuntimeDeviceTracker.cxx, vtkm/cont/TryExecute.cxx. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.

    Warnings:

    • Eligible for the 2.0.x branch.

    The warnings do not need to be fixed, but it is recommended to do so.

    Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

  • Sujin Philip
    Sujin Philip @sujin.philip ·
    Author Contributor

    Do: reformat

  • Kitware Robot
    Kitware Robot @kwrobot ·
    Owner

    This topic has been reformatted and pushed; please fetch from the source repository and reset your local branch to continue with further development on the reformatted commits.

  • Kitware Robot added 1 commit

    added 1 commit

    Compare with previous version

  • Kitware Robot
    Kitware Robot @kwrobot ·
    Owner

    Warnings:

    • Eligible for the 2.0.x branch.

    The warnings do not need to be fixed, but it is recommended to do so.

  • Sujin Philip
    Sujin Philip @sujin.philip ·
    Author Contributor

    @kmorel, I have addressed your comments. could you please take another look? The CI pipeline is green except for ascent which is still failing due to some unrelated issues.

    • Kenneth Moreland
      Kenneth Moreland @kmorel ·
      Maintainer

      +1

      What are the ascent issues? Does it just take a few restarts because ccache is no longer covered?

    • Sujin Philip
      Sujin Philip @sujin.philip ·
      Author Contributor

      So my last run failed. This is the first error:

      [373/757] Building CUDA object vtkm/cont/testing/CMakeFiles/UnitTests_vtkm_cont_testing.dir/UnitTestArrayHandleConcatenate.cxx.o
FAILED: vtkm/cont/testing/CMakeFiles/UnitTests_vtkm_cont_testing.dir/UnitTestArrayHandleConcatenate.cxx.o 
"/autofs/nccsopen-svm1_sw/ascent/spack-envs/base/opt/linux-rhel8-ppc64le/gcc-10.2.0/cmake-3.22.2-obdciox7ht3vd6hzyczn732njexbhans/bin/ctest" --launch --target-name UnitTests_vtkm_cont_testing --build-dir /gpfs/wolf/csc331/proj-shared/vtk-m/ci/runtime/vbolea/builds/KtZfCL_b/001/ecpcitest/vtk-m/build/vtkm/cont/testing --output vtkm/cont/testing/CMakeFiles/UnitTests_vtkm_cont_testing.dir/UnitTestArrayHandleConcatenate.cxx.o --source /gpfs/wolf/proj-shared/csc331/vtk-m/ci/runtime/vbolea/builds/KtZfCL_b/001/ecpcitest/vtk-m/vtkm/cont/testing/UnitTestArrayHandleConcatenate.cxx --language CUDA --filter-prefix "" -- /gpfs/wolf/proj-shared/csc331/vtk-m/ci/utils/ccache /sw/ascent/cuda/11.4.2/bin/nvcc -forward-unknown-to-host-compiler -ccbin=/sw/ascent/gcc/10.2.0-3/bin/g++ -DVTKMDIY_DEBUG -DVTKMDIY_MPI_AS_LIB -DVTKMDIY_NO_THREADS -I/gpfs/wolf/proj-shared/csc331/vtk-m/ci/runtime/vbolea/builds/KtZfCL_b/001/ecpcitest/vtk-m/vtkm/thirdparty/optionparser -I/gpfs/wolf/proj-shared/csc331/vtk-m/ci/runtime/vbolea/builds/KtZfCL_b/001/ecpcitest/vtk-m/vtkm/thirdparty/diy -I/gpfs/wolf/proj-shared/csc331/vtk-m/ci/runtime/vbolea/builds/KtZfCL_b/001/ecpcitest/vtk-m/vtkm/thirdparty/lcl/vtkmlcl -I/gpfs/wolf/proj-shared/csc331/vtk-m/ci/runtime/vbolea/builds/KtZfCL_b/001/ecpcitest/vtk-m -I/gpfs/wolf/csc331/proj-shared/vtk-m/ci/runtime/vbolea/builds/KtZfCL_b/001/ecpcitest/vtk-m/build/include -isystem=/gpfs/wolf/proj-shared/csc331/vtk-m/ci/runtime/vbolea/builds/KtZfCL_b/001/ecpcitest/vtk-m/vtkm/thirdparty/diy/vtkmdiy/include -isystem=/gpfs/wolf/csc331/proj-shared/vtk-m/ci/runtime/vbolea/builds/KtZfCL_b/001/ecpcitest/vtk-m/build/vtkm/thirdparty/diy/vtkmdiy/include/vtkmdiy/mpi --generate-code=arch=compute_70,code=sm_70 -O2 -g -DNDEBUG -Xcompiler=-fvisibility=hidden -Xcompiler=-Wall,-Wcast-align,-Wpointer-arith,-Wformat,-Wformat-security,-Wshadow,-fno-common,-Wunused,-Wno-unknown-pragmas,-Wno-unused-local-typedefs,-Wno-unused-function,-Wchar-subscripts,-Wfloat-conversion,-Wodr -Xcudafe=--display_error_number -Xcompiler=-ffunction-sections --expt-relaxed-constexpr -Xcompiler -pthread -std=c++14 -MD -MT vtkm/cont/testing/CMakeFiles/UnitTests_vtkm_cont_testing.dir/UnitTestArrayHandleConcatenate.cxx.o -MF vtkm/cont/testing/CMakeFiles/UnitTests_vtkm_cont_testing.dir/UnitTestArrayHandleConcatenate.cxx.o.d -x cu -c /gpfs/wolf/proj-shared/csc331/vtk-m/ci/runtime/vbolea/builds/KtZfCL_b/001/ecpcitest/vtk-m/vtkm/cont/testing/UnitTestArrayHandleConcatenate.cxx -o vtkm/cont/testing/CMakeFiles/UnitTests_vtkm_cont_testing.dir/UnitTestArrayHandleConcatenate.cxx.o
In file included from ../vtkm/cont/internal/DeviceAdapterAlgorithmGeneral.h:16,
                 from ../vtkm/cont/cuda/internal/DeviceAdapterAlgorithmCuda.h:27,
                 from ../vtkm/cont/cuda/DeviceAdapterCuda.h:23,
                 from ../vtkm/cont/DeviceAdapter.h:18,
                 from ../vtkm/cont/AtomicArray.h:16,
                 from ../vtkm/cont/arg/TransportTagAtomicArray.h:19,
                 from ../vtkm/worklet/internal/WorkletBase.h:28,
                 from ../vtkm/worklet/WorkletMapField.h:13,
                 from ../vtkm/cont/testing/UnitTestArrayHandleConcatenate.cxx:15:
../vtkm/cont/ArrayHandleDiscard.h:15:10: fatal error: vtkm/internal/Unreachable.h: No such file or directory
   15 | #include <vtkm/internal/Unreachable.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

      But there are also other errors like:

      shell-init: error retrieving current directory: getcwd: cannot access parent directories: No such file or directory
shell-init: error retrieving current directory: getcwd: cannot access parent directories: No such file or directory
shell-init: error retrieving current directory: getcwd: cannot access parent directories: No such file or directory
shell-init: error retrieving current directory: getcwd: cannot access parent directories: No such file or directory
cc1plus: error: ../vtkm/thirdparty/optionparser: Not a directory
cc1plus: error: ../vtkm/thirdparty/diy: Not a directory
cc1plus: error: ../vtkm/thirdparty/lcl/vtkmlcl: Not a directory
cc1plus: error: include: Not a directory
    • Kenneth Moreland
      Kenneth Moreland @kmorel ·
      Maintainer

      Yeah, I've had that happen before. It looks like files and directories just disappear. That seems to be a transient problem. If you restart the build, it will probably go farther.

    • Please register or sign in to reply
  • Sujin Philip added 1 commit

    added 1 commit

    • 0d76d6df - Draft: test reducing no. of jobs on ascent

    Compare with previous version

  • Sujin Philip marked this merge request as draft from sujin.philip/vtk-m@0d76d6df

    marked this merge request as draft from sujin.philip/vtk-m@0d76d6df

  • Kitware Robot
    Kitware Robot @kwrobot ·
    Owner

    Errors:

    • commit 0d76d6df cannot be merged; it is marked as a work-in-progress (WIP).

    Warnings:

    • the merge request is marked as a work-in-progress.

    The warnings do not need to be fixed, but it is recommended to do so.

    Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

  • Kitware Robot
    Kitware Robot @kwrobot ·
    Owner

    Errors:

    • commit 0d76d6df cannot be merged; it is marked as a work-in-progress (WIP).

    Warnings:

    • Eligible for the 2.0.x branch.
    • the merge request is marked as a work-in-progress.

    The warnings do not need to be fixed, but it is recommended to do so.

    Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

  • Kitware Robot
    Kitware Robot @kwrobot ·
    Owner

    Warnings:

    • the merge request is marked as a work-in-progress.

    The warnings do not need to be fixed, but it is recommended to do so.

  • Kitware Robot
    Kitware Robot @kwrobot ·
    Owner

    Warnings:

    • Eligible for the 2.0.x branch.
    • the merge request is marked as a work-in-progress.

    The warnings do not need to be fixed, but it is recommended to do so.

  • Sujin Philip marked this merge request as ready

    marked this merge request as ready

  • Sujin Philip
    Sujin Philip @sujin.philip ·
    Author Contributor

    @kmorel, @vbolea I tried reducing the build parallelism for ascent to see if that helps pass the dashboard. The last pipeline was green, although I can't say for sure if it passed due to the reduced build parallelism (It still took two attempts).

  • Sujin Philip
    Sujin Philip @sujin.philip ·
    Author Contributor

    Do: test

  • Sujin Philip
    Sujin Philip @sujin.philip ·
    Author Contributor

    Do: merge

  • Sujin Philip mentioned in commit 48059d0d

    mentioned in commit 48059d0d

  • Sujin Philip mentioned in commit d05afa72

    mentioned in commit d05afa72

  • Kitware Robot merged

    merged

  • Vicente Bolea mentioned in issue #757 (closed)

    mentioned in issue #757 (closed)

    • Please register or sign in to reply