Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • VTK-m VTK-m
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 212
    • Issues 212
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 39
    • Merge requests 39
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • VTKVTK
  • VTK-mVTK-m
  • Merge requests
  • !2938

Reenable the BenchContour benchmark

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Kenneth Moreland requested to merge kmorel/vtk-m:reenable-contour-benchmarks into master Dec 02, 2022
  • Overview 8
  • Commits 2
  • Pipelines 7
  • Changes 2

MR !2930 (merged) inappropriately commented out the BenchContour benchmarks in BenchmarkFilters. This was probably done accidently in response to a comment that suggested that this benchmark was causing a crash. However, that comment was obsolete. It was introduced in !2196 (merged) when the problem was identified (2 years ago).

The problem suggested by the comment was soon fixed by MR !2197 (merged). At that time the benchmark was reenabled but the comment lingered on even though it was no longer applicable.

This change restores the benchmark again and deletes the obsolete comment.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: reenable-contour-benchmarks