Skip to content
Snippets Groups Projects

Switch how InSitu benchmark iterates

Merged Mark Bolstad requested to merge bolstadm/vtk-m:redo_insitu_benchmark into master

Previous version had a hard-coded loop for updating the dataset. This change relenquishes control over to google benchmarks. Running it from the command-line will iterate each sub-benchmark a different number of iterations depending on how long each individual test takes. The number of iterations can be increased (but not controlled) by increasing the minimum time for each test. Alternatively, using the "repetitions" argument, you can control exactly how many times the benchamrks are run.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • This merge request has been queued for testing. Test results may be viewed on:

    • Gitlab CI builders results can be viewed via the Pipelines for this merge request.
    • CDash links are also available in the Pipelines page
    • CDash (master)
    • Buildbot (master) (only visible from inside Kitware)

    Branch-at-master: 8a95b706

  • Errors:

    • commit 322e20fb is not allowed because the following files are not formatted according to the 'clang-format' check: benchmarking/BenchmarkInSitu.cxx. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.
    • commit 5493c889 is not allowed because the following files are not formatted according to the 'clang-format' check: benchmarking/BenchmarkInSitu.cxx. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.

    Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

  • Author Developer

    Do: reformat

  • This topic has been reformatted and pushed; please fetch from the source repository and reset your local branch to continue with further development on the reformatted commits.

  • Kitware Robot added 3 commits

    added 3 commits

    • 7082bd1b - Switch how InSitu benchmark iterates
    • ef5263a6 - Merge branch 'master' into redo_insitu_benchmark
    • ebee231e - Merge branch 'master' into redo_insitu_benchmark

    Compare with previous version

  • This merge request has been queued for testing. Test results may be viewed on:

    • Gitlab CI builders results can be viewed via the Pipelines for this merge request.
    • CDash links are also available in the Pipelines page
    • CDash (master)
    • Buildbot (master) (only visible from inside Kitware)

    Branch-at-master: ebee231e

  • Mark Bolstad added 5 commits

    added 5 commits

    • 322e20fb - Switch how InSitu benchmark iterates
    • 5493c889 - Merge branch 'master' into redo_insitu_benchmark
    • 8a95b706 - Merge branch 'master' into redo_insitu_benchmark
    • f983d5ec - Fix warnings caught by CI
    • ccf1ce9b - Merge branch 'redo_insitu_benchmark' of...

    Compare with previous version

  • This merge request has been queued for testing. Test results may be viewed on:

    • Gitlab CI builders results can be viewed via the Pipelines for this merge request.
    • CDash links are also available in the Pipelines page
    • CDash (master)
    • Buildbot (master) (only visible from inside Kitware)

    Branch-at-master: ccf1ce9b

  • Errors:

    • commit 322e20fb is not allowed because the following files are not formatted according to the 'clang-format' check: benchmarking/BenchmarkInSitu.cxx. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.
    • commit 5493c889 is not allowed because the following files are not formatted according to the 'clang-format' check: benchmarking/BenchmarkInSitu.cxx. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.
    • commit f983d5ec is not allowed because the following files are not formatted according to the 'clang-format' check: benchmarking/BenchmarkInSitu.cxx. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.

    Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

  • Author Developer

    Do: reformat

  • This topic has been reformatted and pushed; please fetch from the source repository and reset your local branch to continue with further development on the reformatted commits.

  • Kitware Robot added 2 commits

    added 2 commits

    • 84c9895f - Fix warnings caught by CI
    • 829235f3 - Merge branch 'redo_insitu_benchmark' of...

    Compare with previous version

  • This merge request has been queued for testing. Test results may be viewed on:

    • Gitlab CI builders results can be viewed via the Pipelines for this merge request.
    • CDash links are also available in the Pipelines page
    • CDash (master)
    • Buildbot (master) (only visible from inside Kitware)

    Branch-at-master: 829235f3

  • Mark Bolstad added 7 commits

    added 7 commits

    • 322e20fb - Switch how InSitu benchmark iterates
    • 5493c889 - Merge branch 'master' into redo_insitu_benchmark
    • 8a95b706 - Merge branch 'master' into redo_insitu_benchmark
    • f983d5ec - Fix warnings caught by CI
    • ccf1ce9b - Merge branch 'redo_insitu_benchmark' of...
    • 5c8d32c7 - Merge branch 'redo_insitu_benchmark' of...
    • c0c06839 - Fix crash when using '=' with vtkm-device

    Compare with previous version

  • This merge request has been queued for testing. Test results may be viewed on:

    • Gitlab CI builders results can be viewed via the Pipelines for this merge request.
    • CDash links are also available in the Pipelines page
    • CDash (master)
    • Buildbot (master) (only visible from inside Kitware)

    Branch-at-master: c0c06839

  • Errors:

    • commit 322e20fb is not allowed because the following files are not formatted according to the 'clang-format' check: benchmarking/BenchmarkInSitu.cxx. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.
    • commit 5493c889 is not allowed because the following files are not formatted according to the 'clang-format' check: benchmarking/BenchmarkInSitu.cxx. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.
    • commit f983d5ec is not allowed because the following files are not formatted according to the 'clang-format' check: benchmarking/BenchmarkInSitu.cxx. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.
    • commit c0c06839 is not allowed because the following files are not formatted according to the 'clang-format' check: benchmarking/BenchmarkInSitu.cxx. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.

    Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

  • Author Developer

    Do: reformat

  • This topic has been reformatted and pushed; please fetch from the source repository and reset your local branch to continue with further development on the reformatted commits.

  • Kitware Robot added 2 commits

    added 2 commits

    • 3fbb37a5 - Merge branch 'redo_insitu_benchmark' of...
    • 3d422d00 - Fix crash when using '=' with vtkm-device

    Compare with previous version

  • This merge request has been queued for testing. Test results may be viewed on:

    • Gitlab CI builders results can be viewed via the Pipelines for this merge request.
    • CDash links are also available in the Pipelines page
    • CDash (master)
    • Buildbot (master) (only visible from inside Kitware)

    Branch-at-master: 3d422d00

  • Kenneth Moreland resolved all threads

    resolved all threads

  • This merge request has been queued for testing. Test results may be viewed on:

    • Gitlab CI builders results can be viewed via the Pipelines for this merge request.
    • CDash links are also available in the Pipelines page
    • CDash (master)
    • Buildbot (master) (only visible from inside Kitware)

    Branch-at-master: 3d422d00

  • +1

    Please squash the commits before merging.

    Also, we need a section added to the readme in the benchmarks directory that specifically describes how to run the in situ benchmark. (This can happen in a separate MR if you want.)

  • Mark Bolstad added 8 commits

    added 8 commits

    • 322e20fb - Switch how InSitu benchmark iterates
    • 5493c889 - Merge branch 'master' into redo_insitu_benchmark
    • 8a95b706 - Merge branch 'master' into redo_insitu_benchmark
    • f983d5ec - Fix warnings caught by CI
    • ccf1ce9b - Merge branch 'redo_insitu_benchmark' of...
    • 5c8d32c7 - Merge branch 'redo_insitu_benchmark' of...
    • c0c06839 - Fix crash when using '=' with vtkm-device
    • 90ce4bb8 - Add README for running the InSitu benchmark

    Compare with previous version

  • This merge request has been queued for testing. Test results may be viewed on:

    • Gitlab CI builders results can be viewed via the Pipelines for this merge request.
    • CDash links are also available in the Pipelines page
    • CDash (master)
    • Buildbot (master) (only visible from inside Kitware)

    Branch-at-master: 90ce4bb8

  • Errors:

    • commit 322e20fb is not allowed because the following files are not formatted according to the 'clang-format' check: benchmarking/BenchmarkInSitu.cxx. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.
    • commit 5493c889 is not allowed because the following files are not formatted according to the 'clang-format' check: benchmarking/BenchmarkInSitu.cxx. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.
    • commit f983d5ec is not allowed because the following files are not formatted according to the 'clang-format' check: benchmarking/BenchmarkInSitu.cxx. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.
    • commit c0c06839 is not allowed because the following files are not formatted according to the 'clang-format' check: benchmarking/BenchmarkInSitu.cxx. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.
    • commit 90ce4bb8 is not allowed because the following files are not formatted according to the 'clang-format' check: benchmarking/BenchmarkInSitu.cxx. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.
    • missing newline at the end of file in benchmarking/README_insitu.md.

    Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

  • Author Developer

    Do: reformat

  • This topic has been reformatted and pushed; please fetch from the source repository and reset your local branch to continue with further development on the reformatted commits.

  • Kitware Robot added 1 commit

    added 1 commit

    • cfbc9a7c - Add README for running the InSitu benchmark

    Compare with previous version

  • This merge request has been queued for testing. Test results may be viewed on:

    • Gitlab CI builders results can be viewed via the Pipelines for this merge request.
    • CDash links are also available in the Pipelines page
    • CDash (master)
    • Buildbot (master) (only visible from inside Kitware)

    Branch-at-master: cfbc9a7c

  • Errors:

    • missing newline at the end of file in benchmarking/README_insitu.md.

    Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

  • Mark Bolstad added 8 commits

    added 8 commits

    • 322e20fb - Switch how InSitu benchmark iterates
    • 5493c889 - Merge branch 'master' into redo_insitu_benchmark
    • 8a95b706 - Merge branch 'master' into redo_insitu_benchmark
    • f983d5ec - Fix warnings caught by CI
    • ccf1ce9b - Merge branch 'redo_insitu_benchmark' of...
    • 5c8d32c7 - Merge branch 'redo_insitu_benchmark' of...
    • c0c06839 - Fix crash when using '=' with vtkm-device
    • 90ce4bb8 - Add README for running the InSitu benchmark

    Compare with previous version

  • This merge request has been queued for testing. Test results may be viewed on:

    • Gitlab CI builders results can be viewed via the Pipelines for this merge request.
    • CDash links are also available in the Pipelines page
    • CDash (master)
    • Buildbot (master) (only visible from inside Kitware)

    Branch-at-master: 90ce4bb8

  • Errors:

    • commit 322e20fb is not allowed because the following files are not formatted according to the 'clang-format' check: benchmarking/BenchmarkInSitu.cxx. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.
    • commit 5493c889 is not allowed because the following files are not formatted according to the 'clang-format' check: benchmarking/BenchmarkInSitu.cxx. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.
    • commit f983d5ec is not allowed because the following files are not formatted according to the 'clang-format' check: benchmarking/BenchmarkInSitu.cxx. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.
    • commit c0c06839 is not allowed because the following files are not formatted according to the 'clang-format' check: benchmarking/BenchmarkInSitu.cxx. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.
    • commit 90ce4bb8 is not allowed because the following files are not formatted according to the 'clang-format' check: benchmarking/BenchmarkInSitu.cxx. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.
    • missing newline at the end of file in benchmarking/README_insitu.md.

    Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

  • Author Developer

    Do: reformat

  • This topic has been reformatted and pushed; please fetch from the source repository and reset your local branch to continue with further development on the reformatted commits.

  • Kitware Robot added 1 commit

    added 1 commit

    • cfbc9a7c - Add README for running the InSitu benchmark

    Compare with previous version

  • Errors:

    • missing newline at the end of file in benchmarking/README_insitu.md.

    Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

  • This merge request has been queued for testing. Test results may be viewed on:

    • Gitlab CI builders results can be viewed via the Pipelines for this merge request.
    • CDash links are also available in the Pipelines page
    • CDash (master)
    • Buildbot (master) (only visible from inside Kitware)

    Branch-at-master: cfbc9a7c

  • Mark Bolstad added 8 commits

    added 8 commits

    • 322e20fb - Switch how InSitu benchmark iterates
    • 5493c889 - Merge branch 'master' into redo_insitu_benchmark
    • 8a95b706 - Merge branch 'master' into redo_insitu_benchmark
    • f983d5ec - Fix warnings caught by CI
    • ccf1ce9b - Merge branch 'redo_insitu_benchmark' of...
    • 5c8d32c7 - Merge branch 'redo_insitu_benchmark' of...
    • c0c06839 - Fix crash when using '=' with vtkm-device
    • 0509c4a6 - Add README for running the InSitu benchmark

    Compare with previous version

  • This merge request has been queued for testing. Test results may be viewed on:

    • Gitlab CI builders results can be viewed via the Pipelines for this merge request.
    • CDash links are also available in the Pipelines page
    • CDash (master)
    • Buildbot (master) (only visible from inside Kitware)

    Branch-at-master: 0509c4a6

  • Errors:

    • commit 322e20fb is not allowed because the following files are not formatted according to the 'clang-format' check: benchmarking/BenchmarkInSitu.cxx. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.
    • commit 5493c889 is not allowed because the following files are not formatted according to the 'clang-format' check: benchmarking/BenchmarkInSitu.cxx. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.
    • commit f983d5ec is not allowed because the following files are not formatted according to the 'clang-format' check: benchmarking/BenchmarkInSitu.cxx. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.
    • commit c0c06839 is not allowed because the following files are not formatted according to the 'clang-format' check: benchmarking/BenchmarkInSitu.cxx. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.
    • commit 0509c4a6 is not allowed because the following files are not formatted according to the 'clang-format' check: benchmarking/BenchmarkInSitu.cxx. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.
    • missing newline at the end of file in benchmarking/README_insitu.md.

    Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

  • Author Developer

    Do: reformat

  • This topic has been reformatted and pushed; please fetch from the source repository and reset your local branch to continue with further development on the reformatted commits.

  • Kitware Robot added 1 commit

    added 1 commit

    • 8e6ed1ce - Add README for running the InSitu benchmark

    Compare with previous version

  • This merge request has been queued for testing. Test results may be viewed on:

    • Gitlab CI builders results can be viewed via the Pipelines for this merge request.
    • CDash links are also available in the Pipelines page
    • CDash (master)
    • Buildbot (master) (only visible from inside Kitware)

    Branch-at-master: 8e6ed1ce

  • Errors:

    • missing newline at the end of file in benchmarking/README_insitu.md.

    Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading