Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • VTK-m VTK-m
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 192
    • Issues 192
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 35
    • Merge requests 35
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • VTK
  • VTK-mVTK-m
  • Merge requests
  • !2741

Fix point merge for Marching Cubes with multiple isosurfaces

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Kenneth Moreland requested to merge kmorel/vtk-m:fix-mc-merge into master Mar 21, 2022
  • Overview 8
  • Commits 1
  • Pipelines 2
  • Changes 4

When the Marching Cubes algorithm merges points together for multiple isosurfaces, it uses an ArrayHandleZip to combine the isosurface id and the edge identification. This is to prevent merging points from different isosurfaces. However, internally this has to do an array copy.

It was doing this copy with ArrayCopy. A recent change to that method made the copy fail for ArrayHandleZip. The fix is to change to ArrayCopyDevice.

The reason why this bug was introduced was because there was no test case for this specific use. A regression test has been updated to test for this case.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix-mc-merge