Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • VTK-m VTK-m
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 193
    • Issues 193
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 38
    • Merge requests 38
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • VTK
  • VTK-mVTK-m
  • Merge requests
  • !2731

Fix Histogram filter range for DataSet

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Kenneth Moreland requested to merge kmorel/vtk-m:histogram-range into master Mar 16, 2022
  • Overview 4
  • Commits 1
  • Pipelines 2
  • Changes 2

In the transition of the Histogram filter to the new filter types, a bug was introduced. The Histogram filter has an option to set the range for which to compute the histogram. (The range of the data will be used instead if none is specified.) This range was properly used when computing the histogram on a PartitionedDataSet. However, when running on a single DataSet, the new filter structure skipped over the partition code that checked to see if the range was specified. (It also skipped over the code that properly computed the range in MPI.)

This change properly checks to see if Execute was called with a single DataSet and updates the ComputedRange appropriately.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: histogram-range