Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • VTK-m VTK-m
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 192
    • Issues 192
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 35
    • Merge requests 35
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • VTK
  • VTK-mVTK-m
  • Merge requests
  • !2702

Loguru: encapsulate loguru

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Vicente Bolea requested to merge vbolea/vtk-m:encapsulate-loguru-namespace into master Feb 07, 2022
  • Overview 105
  • Commits 5
  • Pipelines 76
  • Changes 7

Fixes: #647 (closed)

This attempts to encapsulate the dependency on Loguru by wrapping all its exposed symbols/macros and not including the luguru headers in VTK-m headers. At the archive/library level the Loguru symbols are not exported as per the fvisibility defaulting to hidden in VTK (I need to recheck this).

P.S. I am trying to move the changes of luguru library introduced here to upstream but it seems that the project is inactive (Last commit 1 year and half ago and several Pull requests ignored) Perhaps we should start thinking into moving to another logging library in the future.

Edited Feb 17, 2022 by Vicente Bolea
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: encapsulate-loguru-namespace