Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • VTK-m VTK-m
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 193
    • Issues 193
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 37
    • Merge requests 37
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • VTK
  • VTK-mVTK-m
  • Merge requests
  • !2698

New filter clean up

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Li-Ta Lo requested to merge ollielo/vtk-m:new_filter_clean_up into master Feb 02, 2022
  • Overview 8
  • Commits 3
  • Pipelines 4
  • Changes 66

There were some oversights in previous MRs related to migration of filters to the new interface (including those originally exists in the legacy code). They don't affect the correctness of filters but should be addressed. For example:

  1. auto field = ... => const auto& field = ...
  2. move around or inline previous item to prevent accidental lambda capture.
  3. [&, this] => [&]
  4. Use the Field overload of CastAndCall*Field.
  5. restructure contour/worklet and density_estimate/worklet.
  6. explicit keyword for constructors taking a single parameter.
  7. remove default constructor where it is necessary/correct/safe to prevent un-inited data members.
  8. remove unnecessary #include.
  9. other issues reported by clang-tidy.

There are many other issues reported by clang-tidy at the Worklet level. Unless they are very obviously true positive, they are left untouched.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: new_filter_clean_up