Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • VTK-m VTK-m
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 193
    • Issues 193
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 38
    • Merge requests 38
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • VTK
  • VTK-mVTK-m
  • Merge requests
  • !2647

Add UncertainCellSet

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Kenneth Moreland requested to merge kmorel/vtk-m:unknown-cell-set into master Dec 13, 2021
  • Overview 50
  • Commits 5
  • Pipelines 24
  • Changes 14

The DynamicCellSet class has been replaced with UnknownCellSet. Likewise, the DynamicCellSetBase class (a templated version of DynamicCellSet) has been replaced with UncertainCellSet.

These changes principally follow the changes to the UnknownArrayHandle management class. The ArrayHandle version of a polymorphic manager has gone through several refinements from DynamicArrayHandle to VariantArrayHandle to its current form as UnknownArrayHandle. Throughout these improvements for ArrayHandle, the equivalent classes for CellSet have lagged behind. The CellSet version is decidedly simpler because CellSet itself is polymorphic, but there were definitely improvements to be had.

The biggest improvement was to remove the templating from the basic unknown cell set. The old DynamicArrayHandle was actually a type alias for DynamicArrayHandleBase<VTKM_DEFAULT_CELL_SET_LIST>. As VTKM_DEFAULT_CELL_SET_LIST tends to be pretty long, DynamicArrayHandle was actually a really long type. In contrast, UnknownArrayHandle is its own untemplated class and will show up in linker symbols as such.

Edited Dec 15, 2021 by Kenneth Moreland
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: unknown-cell-set