Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • VTK-m VTK-m
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 205
    • Issues 205
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 35
    • Merge requests 35
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • VTKVTK
  • VTK-mVTK-m
  • Merge requests
  • !2606

Fix newline issue in reproduce_ci_env.py

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Kenneth Moreland requested to merge kmorel/vtk-m:reproduce-ci-fix into master Oct 13, 2021
  • Overview 8
  • Commits 1
  • Pipelines 6
  • Changes 1

MR !2598 (merged) introduced some fixes to reproduce_ci_env.py. One of them handled newlines in command lists by separating the command lists by newlines in the Dockerfile (which generated a script). Although this worked for some of the docker containers, I found others, like rhel8, where the newlines were not escaped correctly.

Correct this problem by moving back to separating commands with &&. This requires replacing newlines in commands with &&. That in itself is no problem except that if you have a blank line, you get && &&, which is a syntax error for the shell. So, avoid this by stripping newlines from commands.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: reproduce-ci-fix