Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • VTK-m VTK-m
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 212
    • Issues 212
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 40
    • Merge requests 40
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • VTKVTK
  • VTK-mVTK-m
  • Merge requests
  • !2580

Consolidate count-to-offset algorithms

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Kenneth Moreland requested to merge kmorel/vtk-m:consolidate-count-to-offset into master Sep 16, 2021
  • Overview 23
  • Commits 2
  • Pipelines 4
  • Changes 29

For no particularly good reason, there were two functions that converted and array of counts to an array of offsets: ConvertNumComponentsToOffsets and ConvertNumIndicesToOffsets. These functions were identical, except one was defined in ArrayHandleGroupVecVariable.h and the other was defined in CellSetExplicit.h.

These two functions have been consolidated into one (which is now called ConvertNumComponentsToOffsets). The consolidated function has also been put in its own header file: ConvertNumComponentsToOffsets.h.

Normally, backward compatibility would be established using deprecated features. However, one of the things being worked on is the removal of device-specific code (e.g. vtkm::cont::Algorithm) from core classes like CellSetExplicit so that less code needs to use the device compiler (especially downstream code).

Part of this change removed unnecessary includes of Algorithm.h in ArrayHandleGroupVecVariable.h and CellSetExplicit.h. This header had to be added to some classes that were not including it themselves.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: consolidate-count-to-offset