Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • VTK-m VTK-m
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 188
    • Issues 188
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 38
    • Merge requests 38
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

An update will be applied May 24th, between 12PM and 1PM EDT (UTC -400). The site may be slow during that time.

  • VTK
  • VTK-mVTK-m
  • Merge requests
  • !2552

Merged
Created Aug 06, 2021 by Kenneth Moreland@kmorelMaintainer

Fix recursive header file dependancies for UnknownArrayHandle

  • Overview 9
  • Commits 1
  • Pipelines 2
  • Changes 4

Having UnknownArrayHandle.h include DefaultTypes.h is problematic, because that header includes lots of other classes like cell sets. Keeping these from in turn depending back on UnknownArrayHandle.h is difficult. So this MR breaks this dependency. UnknownArrayHandle no longer includes DefaultTypes.h, so DefaultTypes.h and all of its dependencies can in turn include UnknownArrayHandle.h.

This change is required for features like !2551 (merged) where a core class wants to use UnknownArrayHandle to compile something in a library without templates.

Edited Aug 10, 2021 by Kenneth Moreland
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix-unknownah-circular-dependency