Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • VTK-m VTK-m
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 195
    • Issues 195
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 34
    • Merge requests 34
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • VTK
  • VTK-mVTK-m
  • Merge requests
  • !2387

Fix runaway deprecation suppression

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Kenneth Moreland requested to merge kmorel/vtk-m:runaway-deprecate-suppress into master Jan 25, 2021
  • Overview 21
  • Commits 3
  • Pipelines 14
  • Changes 119

Field.h had a runaway deprecation suppression where the pragmas to suppress deprecation warnings were turned on but not properly turned off. This caused deprecation warnings to be turned off for anything including Field.h (directly or indirectly), and consequently lots of use of deprecated features went unnoticed.

The majority of the warnings were caused by the use of the deprecated Cast, CopyTo, and ResetTypes methods of UnknownArrayHandle (or VariantArrayHandle). Both Cast and CopyTo have been subsumed by AsArrayHandle (to make the functionality more clear). ResetTypes now requires a second template argument to define the storage types to try.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: runaway-deprecate-suppress