Skip to content

vtkm::AtomicLoad should only occur on non-const values

Robert Maynard requested to merge robertmaynard/vtk-m:correct_atomic_load_api into master

Previously vtk-m allowed users to issue atomic loads on constant values which is problematic for the following reasons:

  • can be a source of undefined behavior
  • not supported by kokkos

This issue was detected when using kokkos HIP atomic implementation

Merge request reports