Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
VTK-m
VTK-m
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 150
    • Issues 150
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 21
    • Merge Requests 21
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • VTK
  • VTK-mVTK-m
  • Merge Requests
  • !2261

Merged
Opened Sep 14, 2020 by Kenneth Moreland@kmorelMaintainer

Remove virtual methods from ColorTable

  • Overview 16
  • Commits 4
  • Pipelines 10
  • Changes 13

Virtual methods are being deprecated, so remove their use from the ColorTable classes. Instead of using a virtual method to look up a value in the ColorTable, we essentially use a switch statement. This change also simplified the code quite a bit.

The execution object used to use pointers to handle the virtual objects. That is no longer necessary, so a simple vtkm::exec::ColorTable is returned for execution objects. (Note that this ColorTable contains pointers that are specific for the particular device.) This is a non- backward compabible change. However, the only place (outside of the ColorTable implementation itself) was a single worklet for converting scalars to colors (vtkm::worklet::colorconversion::TransferFunction). This is unlikely to affect anyone.

I also "fixed" some names in enum structs. There has been some inconsistencies in VTK-m on whether items in an enum struct are capitolized or camel case. We seem to moving toward camel case, so deprecate some old names.

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: vtk/vtk-m!2261
Source branch: color-table-no-virtual