Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • VTK-m VTK-m
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 206
    • Issues 206
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 41
    • Merge requests 41
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Terraform modules
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • VTKVTK
  • VTK-mVTK-m
  • Merge requests
  • !2191

Fix race condition in UnitTestGraphConnectivity

  • Review changes

  • Download
  • Patches
  • Plain diff
Closed Kenneth Moreland requested to merge kmorel/vtk-m:graph-connectivity-race-condition into master Jul 21, 2020
  • Overview 26
  • Commits 1
  • Pipelines 4
  • Changes 4

The UnitTestGraphConnectivity would sometimes fail on parallel devices (even though the tested graph is remarkably small). The issue was likely a race condition in the pointer jumping worklets where the worklet would check graph edges in an array and then update the connections in the same array.

These race conditions are removed by reading input connections from one array and writing the results to a separate array. The algorithm now seems more stable although it now requires more memory.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: graph-connectivity-race-condition