Test BOV reader. Fix slow WritePortal().Set(idx, val) loop. (!2081) · Merge requests · VTK / VTK-m

The source project of this merge request has been removed.

Nick Thompson requested to merge (removed):bov_test into master May 11, 2020

This removes another antipattern: The WritePortal().Set(idx, val) loop. Fortunately this does not appear to be pervasive in the codebase; the only place I could find it (outside of unit tests) was in BoundingVolumeHierarchy.cxx, and in a 3 element loop; not a long one.

Note that if a user does in fact create a performance bug with a WritePortal().Set(idx, val) loop, the perf report will show it halted in a spinlock:

Once the performance bug has been removed, you see what you expect: Writes to containers dominating the runtime:

Edited May 11, 2020 by Nick Thompson

Test BOV reader. Fix slow WritePortal().Set(idx, val) loop.

Merge request reports