Skip to content

For VTK-m libs all includes of DeviceAdapterTagCuda happen from cuda files

Robert Maynard requested to merge robertmaynard/vtk-m:no_odr_violation_on_cuda_tag into master

It is very easy to cause ODR violations with DeviceAdapterTagCuda. If you include that header from a C++ file and a CUDA file inside the same program we an ODR violation. The reasons is that the C++ versions will say the tag is invalid, and the CUDA will say the tag is valid.

The solution to this is that any compilation unit that includes DeviceAdapterTagCuda from a version of VTK-m that has CUDA enabled must be invoked by the cuda compiler.

Merge request reports