Remove ability to pass a runtime device tracker to TryExecute

Since runtime device trackers are single instance per thread the ability to pass them around to other functions is unneeded.

This merge request has been queued for testing. Test results may be viewed on:

• CDash (master)
• Buildbot (master) (only visible from inside Kitware)

Branch-at-master: d38e61c1

Errors:

• commit d38e61c1 is not allowed because the following files are not formatted according to the 'clang-format-3.8' check: vtkm/cont/ArrayCopy.h, vtkm/cont/ArrayRangeCompute.h, vtkm/cont/ArrayRangeCompute.hxx, vtkm/cont/TryExecute.h. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.

Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

Do: reformat

This topic has been reformatted and pushed; please fetch from the source repository and reset your local branch to continue with further development on the reformatted commits.

added 1 commit

• 6fd60f63 - Remove ability to pass a runtime device tracker to TryExecute

Compare with previous version

This merge request has been queued for testing. Test results may be viewed on:

• CDash (master)
• Buildbot (master) (only visible from inside Kitware)

Branch-at-master: 6fd60f63

@kmorel Do you have any objections to these changes? Specifically the new API for ArrayCopy and ArrayRangeCompute?

Do you think ArrayCopy and ArrayRangeCompute should be able to (optionally) take a DeviceAdapterId?

That sounds like a nice approach.

Other than that, +1

Looking at ArrayCopy I don't see the value of adding a DeviceAdapterId. The run-time version already has some 'smarts' to select the device where the input array was last executed on.

The more I think about it, I think what we should do is the following:

1. Move the ArrayCopy smart logic over to vtkm::cont::Algorithm::Copy
2. Make the run-time version of ArrayCopy a light wrapper around vtkm::cont::Algorithm::Copy
3. Remove the device adapter templated version of ArrayCopy as it isn't used at all currently

@kmorel thoughts?

I'm fine with that. Should we just deprecate ArrayCopy, or is it a handy shortcut?

I didn't want to remove it as it looks to be used by numerous worklets.

added 1 commit

• 26899aee - Remove ability to pass a runtime device tracker to TryExecute

Compare with previous version

This merge request has been queued for testing. Test results may be viewed on:

• CDash (master)
• Buildbot (master) (only visible from inside Kitware)

Branch-at-master: 26899aee

Errors:

• commit 26899aee is not allowed because the following files are not formatted according to the 'clang-format-3.8' check: vtkm/cont/Algorithm.h, vtkm/cont/ArrayCopy.h, vtkm/cont/ArrayRangeCompute.h, vtkm/cont/ArrayRangeCompute.hxx, vtkm/cont/TryExecute.h. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.

Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

@kmorel I have made the above changes to ArrayCopy and ArrayRange are you happy with all these changes now?

+1

Do: reformat

This topic has been reformatted and pushed; please fetch from the source repository and reset your local branch to continue with further development on the reformatted commits.