Merge FilterField into Filter?
The FilterField
class does not change the basic functionality of its superclass, Filter
. It just adds methods to manage input and output fields. But, unlike the previous filter interface in VTK-m 1.X, the calling mechanism for DoExecute
remains the same.
Since FilterField
and Filter
operate the same way, it can be confusing which one to use. The only real reason to keep them separate is because some filters do not need to select any input fields or produce any new output field and thus do not need the added features of FilterField
. However, there are instances of filters that only need parts of the functionality of FilterField
. For example, the contour filters need to select an input field, but produce no special named output field, hence ignoring that part of the API.
I propose moving the functionality of FilterField
into Filter
and just provide the same complete interface to all filter classes. Once this functionality is moved, FilterField
will be an empty subclass that can be deprecated in favor of using Filter
directly.