Skip to content
Snippets Groups Projects

Extra DeviceAdapterAlgorithm Documentation (CountSetBits, BitFieldToUnorderedSet, ScanExtended, Fill, Transform)

Merged Nickolas Davis requested to merge scan-extended into master

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Author Developer

    I just want to note that I planned on documenting the other functions in DeviceAdapterAlgorithms that don't seem to have Users Guide entries yet (Fill, Transform, and StreamingScanExclusive), but am working on those in another branch. The examples weren't building due to the changes in master so I focused on updating those here.

    Edited by Nickolas Davis
    • Resolved by Nickolas Davis

      @nadavi I note that this merge request has 2 independent changes in it: updating the DeviceAdapter documentation and fixing changes in CellSetExplicit code. In general, you should try not to do that. If you have 2 (or more) independent changes, you should make a separate git branch and subsequent merge request for each one.

      The problem is that the merging of each of these changes now relies on the other being correct. In this instance, the fixes for CellSetExplicit are ready to be merged, but they can’t be because the unrelated changes to the DeviceAdapter documentation are not ready. That in turn causes problems for collaborators (in this case, me) because I cannot get your fixes for CellSetExplicit that I need to continue making changes for the upcoming tutorial and release.

      In the future when you are working on one feature (whether it is this user’s guide or VTK-m proper) and you find you need to make changes to something else, you should create a new branch off of master and implement it independently.

  • I took a look through this and left some suggestions, but wanted to say thanks for doing the update! I tend to forget about the user guide when pushing these patches...

  • Nickolas Davis changed title from Extra DeviceAdapterAlgorithm Documentation (CountSetBits, BitFieldToUnorderedSet, ScanExtended); CellSetExplicit Example Updates to Extra DeviceAdapterAlgorithm Documentation (CountSetBits, BitFieldToUnorderedSet, ScanExtended)

    changed title from Extra DeviceAdapterAlgorithm Documentation (CountSetBits, BitFieldToUnorderedSet, ScanExtended); CellSetExplicit Example Updates to Extra DeviceAdapterAlgorithm Documentation (CountSetBits, BitFieldToUnorderedSet, ScanExtended)

  • Nickolas Davis added 1 commit

    added 1 commit

    • c6fc5ea2 - Fixes to get DeviceAdapterAlgorithms compiling

    Compare with previous version

  • Nickolas Davis added 18 commits

    added 18 commits

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading