Fix index out of bounds runtime crash

VTK testing needs threads, so the CMake code will turn it back on.

What really needs to be done is either disable testing or

1. Add "-pthread" to compile options of each example.
2. Add "-pthread" "-sPROXY_TO_PTHREAD=1" "-sOFFSCREENCANVAS_SUPPORT=1" to link options of each example.

Modify the http headers of static server to support SharedArrayBuffer

Example with python server - https://gist.github.com/pezcode/d51926bdbadcbd4f22f5a5d2fb8e0394

Mmh strange, I tested the build locally and it seemed to work both with -DVTK_BUILD_TESTING=ON and -DVTK_WEBASSEMBLY_THREADS=OFF
I'll try as well with the link options you provided. Thanks!
The reason will build testing if for some examples eg GenericClip which needs the Testing module

Okay! It ain't broke if it works. The link options are only required when VTK_WEBASSEMBLY_THREADS=ON.

The reason will build testing if for some examples eg GenericClip which needs the Testing module

I see, because it needs vtkBridgeDataSet from TestingGeneric module.

I'm on the fence about enabling threads in the vtk-examples website because it's not easy to customize http headers when hosting from github pages - https://docs.wasmer.io/javascript-sdk/how-to/coop-coep-headers

Ok! The assets are served from the vtk.org, we have control over the HTTP headers sent. Or you're already aware of that and the headers really needs to be sent by the github pages host. Need to be tried probably

Not sure if the assets include the index.html page of an example. Basically, that main page for an example needs those headers so that browser can enable SharedArrayBuffer

I think it does, iirc

assigned to @jules.bourdais

added 1 commit

• f9f399e7 - bump build environment to emsdk 3.1.60

Compare with previous version

The built examples works fine with the current options

+2

marked this merge request as ready

mentioned in commit 76ab25c7

merged