Skip to content
Snippets Groups Projects

VR improvements

Merged Bernhard Fröhler requested to merge codeling/vtk-examples:VRImprovements into master
1 unresolved thread

As far as I could see there was no OpenXR example yet - I have added a short one showing a cone (similar to the OpenVR example as well as other simple geometric object examples). Also, not all OpenVR examples were listed on the respective C++ overview, so I've added them there.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    1. Make sure that there are corresponding images as in the existing OpenVR examples. These will go in src/Testing/Baseline/Cxx/GeometricObjects/.
    2. Make sure that for any extra OpenVR OpenXR examples that the needed information is added to section: include(${WikiExamples_SOURCE_DIR}/CMake/RequiresModule.cmake) in src/Cxx/GeometricObjects/CmakeLists.txt. I see you have done that for the OpenXR example but check for the other OpenVR examples you added in the second commit.
    3. In src/Admin/WASM/exclude_wasm.txt update around line 209 adding in your new example and also check if all the other examples are there.
  • added 1 commit

    • 10f51fe1 - Add OpenXRCone to exclude_wasm list

    Compare with previous version

    • Thanks for the feedback! For 1., I have tried adding an image for OpenXRCone, but push fails (with LFS issues, same as back with this pull request: !295 (merged)):

      $ git push
      warning: Authentication error: Authentication required: Access forbidden. Check your access level.
      Uploading LFS objects:   0% (0/1), 0 B | 0 B/s, done.
      batch response: Access forbidden. Check your access level.
      error: failed to push some refs to 'gitlab.kitware.com:codeling/vtk-examples.git'

      Here is the image: TestOpenXRCone

      For all others there already existed an image. For 2., also all required modules were already added as far as I can see. For 3. I have added the new new OpenXR example, all other OpenVR examples were there already as well.

    • THe push will fail because of git-lfs. The only way around this is to directly check out the VTK master create a branch from it and work on it.

      If you want, I can just copy the above image and add it after merging.

    • THe push will fail because of git-lfs. The only way around this is to directly check out the VTK master create a branch from it and work on it.

      I would do it myself but I'm not sure there is something I can do here. Do you mean the master branch of this repository, vtk-examples? I have tried that in my other merge request - the MultiBlockVolumeMapper branch is directly based off the current master, and I still could not push a commit containing a .png (same error message as shown above), also when I merged it to master and tried to push that to my fork, I get a slightly shorter output, but similar error:

      $ git push
      warning: Authentication error: Authentication required: Access forbidden. Check your access level.
      batch response: Access forbidden. Check your access level.
      error: failed to push some refs to 'gitlab.kitware.com:codeling/vtk-examples.git'

      Or do you mean another repository?

      Edited by Bernhard Fröhler
    • Your local master should be directly checking the origin master (not forking it). In both your MRs it is tracking your codeling ones.

    • Please register or sign in to reply
  • Bernhard Fröhler mentioned in merge request !355 (merged)

    mentioned in merge request !355 (merged)

  • Andrew Maclean approved this merge request

    approved this merge request

  • Andrew Maclean mentioned in commit 9cf09b97

    mentioned in commit 9cf09b97

  • Thanks fo this, I'll add the image.

Please register or sign in to reply
Loading