Skip to content
Snippets Groups Projects
  1. Feb 24, 2017
  2. Feb 23, 2017
  3. Feb 22, 2017
  4. Feb 21, 2017
  5. Feb 20, 2017
  6. Feb 19, 2017
  7. Feb 18, 2017
  8. Feb 17, 2017
    • Utkarsh Ayachit's avatar
    • Utkarsh Ayachit's avatar
      Remove obolete code to handle LZ4 support. · c6735eae
      Utkarsh Ayachit authored
      Code was not needed since 5.1. Removed it.
      c6735eae
    • Utkarsh Ayachit's avatar
      Fix tracing/saving state of representation property. · c1954d50
      Utkarsh Ayachit authored
      Addresses #17196.
      
      The issue is a tricky one. Here's the synopsis. When tracing or saving
      state in Python, we only save state for properties that are different
      from the default. This generally is a good strategy for minimizing trace
      verbosity. Now, for a property with `vtkSMRepresentationTypeDomain`, the
      default is changed by the domain (in our case to `Outline` from
      `Surface`). For the bug, we changed it back to `Surface` -- now same as
      default. Hence, when saving the state file, the code skipped the
      property as it's value was unchanged from the default -- causing the
      bug.
      
      As a fix, we force the tracing mechanism (also used in when saving state
      as Python) to save the "Representation" property, even if it hasn't
      changed from the default value.
      
      A better fix maybe to add support to vtkSMProperty to know that it was
      changed since initialization -- but that needs some pondering.
      c1954d50
Loading