Skip to content

SystemTools: Fix CollapseFullPath performance regression on Windows

Brad King requested to merge brad.king/kwsys:SystemTools-move-path-case-cache into master

!68 (merged) regressed the performance of CollapseFullPath on Windows where it calls GetActualCaseForPath because it is often called with non-existent paths. Revert it. Fix the original issue instead by removing caching from the publicly observable behavior of GetActualCaseForPath. Use a cache privately for CollapseFullPath instead, and cache even results for non-existent paths.

Issue: cmake/cmake#17315 (closed)

Merge request reports