Commit 4b537c59 authored by Robert Maynard's avatar Robert Maynard Committed by Brad King
Browse files

Tests: Handle that root users on linux can always write to files

It is common when running software from a container setup such
as docker that the user is root. Because of this, some permission
checks are pointless as the root user ( uid=0 ) can always do
things such as write to files.
parent 4380f1ae
......@@ -328,7 +328,14 @@ static bool CheckFileOperations()
}
// While we're at it, check proper TestFileAccess functionality.
if (kwsys::SystemTools::TestFileAccess(testNewFile,
bool do_write_test = true;
#if defined(__linux__)
// If we are running as root on linux ignore this check, as
// root can always write to files
do_write_test = (getuid() != 0);
#endif
if (do_write_test &&
kwsys::SystemTools::TestFileAccess(testNewFile,
kwsys::TEST_FILE_WRITE)) {
std::cerr
<< "TestFileAccess incorrectly indicated that this is a writable file:"
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment