- Mar 08, 2023
-
-
Eric Engestrom authored
-
Eric Engestrom authored
-
Samuel Pitoiset authored
All formats should be compatible on GFX11 but for some weird reasons DCC with signedness reinterpretation doesn't work as expected, like R8_UINT<->R8_SINT. Note that RadeonSI also has issues with this. This might be a hardware bug on RDNA3. This fixes DCC issues with Cyberpunk and A Plague Tale: Requiem. Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8020 Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8371 Cc: mesa-stable Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21755> (cherry picked from commit e6735409)
-
Samuel Pitoiset authored
RADV_USE_WSI_PLATFORM was unused in radv_CreateImage(). Fixes: 2a5d7f49 ("radv: fix missing implementation of creating images from swapchains") Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21763> (cherry picked from commit c87c34bb)
-
Samuel Pitoiset authored
Swizzle of 8-bit stencil format is defined as _x__ but the hw expects BC_SWIZZLE_XYZW. Fixes dEQP-VK.pipeline.monolithic.sampler.border_swizzle.*s8_uint*. Cc: mesa-stable Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21482> (cherry picked from commit 7b2086d7)
-
Yogesh Mohan Marimuthu authored
Modifying pitch for all LINEAR surface isn't correct; the original change that modified surf_pitch was only intended for YUV textures. This fixes vkGetImageSubresourceLayout rowPitch return value for VK_FORMAT_BC3_UNORM_BLOCK + VK_IMAGE_TILING_LINEAR. Fixes: fcc499d5 (ac/surface: adjust gfx9.pitch[*] based on surf->blk_w) v2: add check for UYVY format (Pierre-Eric) v3: move blk_w division to above if check (Pierre-Eric) Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21595> (cherry picked from commit 347a5b79)
-
Samuel Pitoiset authored
When the query pool uses GDS (for NGG), the stride is 40. Cc: mesa-stable Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8412 Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21650> (cherry picked from commit c119b19f)
-
Lionel Landwerlin authored
Both GLSL & SPIRV have undefined values for shift > bitsize. But SM5 says : "This instruction performs a component-wise shift of each 32-bit value in src0 left by an unsigned integer bit count provided by the LSB 5 bits (0-31 range) in src1, inserting 0." Better to not hard code the wrong behavior in NIR. Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Fixes: e227bb9f ("nir/builder: add ishl_imm helper") Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@colllabora.com> Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21720> (cherry picked from commit a278eeb7)
-
Karol Herbst authored
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8267 Fixes: b0d698c5 ("rusticl: correctly check global argument size") Signed-off-by: Karol Herbst <kherbst@redhat.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21604> (cherry picked from commit 4c24ff0a)
-
Mike Blumenkrantz authored
this is otherwise unreliable cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21739> (cherry picked from commit a4b1ae1f)
-
Mike Blumenkrantz authored
this could unset the update flag if the last ssbo was null, which would be a bug if it could ever be triggered found by inspection cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21739> (cherry picked from commit 7145ccfa)
-
Mike Blumenkrantz authored
this otherwise may have been a surface that was never drawn to or already had its layout corrected, in which case a deferred barrier is not only unnecessary, it might be broken cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21739> (cherry picked from commit e0dfe058)
-
Sam Edwards authored
This may happen if the Nouveau device fails to initialize before the pushbuf is set up; the abort logic will call this either way. Signed-off-by: Sam Edwards <CFSworks@gmail.com> Reviewed-by: Karol Herbst <kherbst@redhat.com> Cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21611> (cherry picked from commit 9de997bd)
-
Mike Blumenkrantz authored
this ensures that batch refs are added for fb surfaces on unbind, which prevents stale batch tracking from persisting on resources after the context is destroyed fixes: *EGL.functional.render.multi_context* cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21727> (cherry picked from commit 62f1a8a3)
-
Ruijing Dong authored
reason: some h264 streams have some strange pictures, from vaapi input these pictures don't have a reference frame, however, they are not intra only pictures, in MB layer these pictures are looking for some references, if they cannot find it. It could cause PF. when reference pictures exist, it will need to set used_for reference_flags, therefore if that is set, however the number of reference frames is zero, which is odd, it should be avoided. solution: In the above case, to scan the ref list so that it will make at least one reference available to avoid crash, since this is not accurate enough, it could cause some artifacts. And in that case, it will need to be checked individually for another solution. closes: https://gitlab.freedesktop.org/drm/amd/-/issues/1462 closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8401 Cc: mesa-stable Tested-by: llyyr <llyyr.public@gmail.com> Reviewed-by: Leo Liu <leo.liu@amd.com> Signed-off-by: Ruijing Dong <ruijing.dong@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21732> (cherry picked from commit 0f3370ee)
-
Eric Engestrom authored
-
Mike Blumenkrantz authored
this was accurately returning whether the access had only write flags, but it was incorrectly returning false for READ|WRITE cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21583> (cherry picked from commit 5be506c1)
-
Gert Wollny authored
Fixes: 56dedf05 r600/sfn: add r600 specific lowering pass for atomics and use it Signed-off-by: Gert Wollny <gert.wollny@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21684> (cherry picked from commit 9b09f244)
-
Lionel Landwerlin authored
cmd_buffer_update_dirty_vbs_for_gfx8_vb_flush takes a value RANDOM/SEQUENTIAL. Not a boolean. Fortunately this worked okay because true == RANDOM Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Cc: mesa-stable Reviewed-by: Tapani Pälli <tapani.palli@intel.com> Reviewed-by: Ivan Briano <ivan.briano@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20497> (cherry picked from commit 4246a519)
-
Lionel Landwerlin authored
The WA is meant to be here to apply some state that is not propagated properly inside the HW. But if you have a loop like : for ( ... ) { emit(3DPRIMITIVE, some param); } You're not really changing any state, just push more draws into the pipeline. Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Fixes: f2645229 ("anv: implement Wa_14016118574") Reviewed-by: Tapani Pälli <tapani.palli@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21660> (cherry picked from commit 6ee7a2ec)
-
Marek Olšák authored
Oops. Fixes: c8e2c6fa ("radeonsi: use SET_SH_REG_INDEX with index=3 for registers containing CU_EN") Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21641> (cherry picked from commit 3a26d2b1)
-
Samuel Pitoiset authored
The hardware requires one color output to be set by CB registers, otherwise the DCC decompression does nothing. Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8127 Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8175 Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8370 Cc: mesa-stable Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21629> (cherry picked from commit 4ec68502)
-
Mike Blumenkrantz authored
this otherwise can do weird things cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21628> (cherry picked from commit f7d1fff2)
-
Yogesh Mohan Marimuthu authored
vulkancts test dEQP-VK.wsi.direct_drm.surface.create_simulate_oom is failing because in wsi_display_alloc_connector() function memory allocation for connector is not checked for return NULL. create_simulate_oom test simulates out of memory, hence memory allocation fails for connector and later when tried to dereference connector program will segfault. This patch fixes the dEQP-VK.wsi.direct_drm.surface.create_simulate_oom test segfault issue by checking if connector is NULL afer memory allocation. Cc: mesa-stable Reviewed-by: Eric Engestrom <eric@igalia.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21701> (cherry picked from commit af953616)
-
Sil Vilerino authored
Fixes: c8e8ce83 ("d3d12: Add VP9 Decode support") Reviewed-by: Jesse Natalie <jenatali@microsoft.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21694> (cherry picked from commit fb823715)
-
Sil Vilerino authored
Fixes: c8e8ce83 ("d3d12: Add VP9 Decode support") Reviewed-by: Jesse Natalie <jenatali@microsoft.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21694> (cherry picked from commit 6fea823d)
-
Lionel Landwerlin authored
With softpin we should not always expect a BO in addresses. Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Cc: mesa-stable Reviewed-by: Tapani Pälli <tapani.palli@intel.com> Reviewed-by: Ivan Briano <ivan.briano@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20497> (cherry picked from commit f5dc8891)
-
Lionel Landwerlin authored
We don't want the WA to kick-in if it's not point/line topology. Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Fixes: f2645229 ("anv: implement Wa_14016118574") Reviewed-by: Tapani Pälli <tapani.palli@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21660> (cherry picked from commit d82e8e01)
-
Väinö Mäkelä authored
Using texelFetch to read samples from an 8xMSAA fast cleared image on Haswell can read transparent black pixels around triangles from where there should be none. This issue isn't present when using sample shading, resolving the image using vkCmdResolveImage or in a copy the image. The easiest way to fix this is by just disabling non-zero fast clears for 8xMSAA images. Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/7587 Cc: mesa-stable Reviewed-by: Filip Gawin <filip@gawin.net> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21444> (cherry picked from commit e509afac)
-
Tatsuyuki Ishi authored
After cross-checking with kernel and the old buffer copy code, it seems that the size field should be size - 1 instead. Fixes: 7b5ab48c ("radv: partial sdma support") Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21585> (cherry picked from commit e9a55b33)
-
Tatsuyuki Ishi authored
After cross-checking with kernel and the old buffer copy code, it seems that the size field should be size - 1 instead. Fixes: 46c95047 ("radeonsi: implement si_sdma_copy_image for gfx7+") Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21585> (cherry picked from commit 4f50497a)
-
Eric Engestrom authored
-
Samuel Pitoiset authored
This crashed on Steam Deck because the memory type is LPDDR5 and it wasn't not handled in the switch. It seems the kernel changed the memory type returned for VanGogh because it used to work. Fixes: aef7ea86 ("ac/gpu_info: handle LPDDR4 and 5 in ac_memory_ops_per_clock") Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Marek Olšák <marek.olsak@amd.com> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21627> (cherry picked from commit f19fccd9)
-
Yiwei Zhang authored
Fixes: 8b810985 ("venus: enable VK_EXT_image_view_min_lod") Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21617> (cherry picked from commit 054a8349)
-
Lionel Landwerlin authored
I wonder if the docs are correct for Gfx11 because this is the generation that gave us the Bindless Sampler Heap of 4Gb. So it would make sense that the border colors can also be placed anywhere in that 4Gb heap. Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Cc: mesa-stable Reviewed-by: José Roberto de Souza <jose.souza@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21600> (cherry picked from commit 42e8a2c1)
-
Lionel Landwerlin authored
BSpec 44507 Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Cc: mesa-stable Reviewed-by: José Roberto de Souza <jose.souza@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21600> (cherry picked from commit 58b687d7)
-
Dave Airlie authored
On 32-bit systems llvm will only be dealing with 32-bit ptrs Reviewed-by: Karol Herbst <kherbst@redhat.com> Cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21601> (cherry picked from commit 53dda476)
-
Samuel Pitoiset authored
The correct workaround is to bind an internal index buffer to handle robustness2 correctly. Fixes dEQP-VK.robustness.index_access.* in CTS 1.3.5.0 on NAVI10. Cc: mesa-stable Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21471> (cherry picked from commit c356f1b4)
-
Samuel Pitoiset authored
The condition was inverted. This doesn't fix anything known. Cc: mesa-stable Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21549> (cherry picked from commit 7c62f6fa)
-
Samuel Pitoiset authored
Fixes dEQP-VK.draw.dynamic_rendering.complete_secondary_cmd_buff.multi_draw.mosaic.* on VEGA10 (related to the use of HTILE). Cc: mesa-stable Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21549> (cherry picked from commit 6750a909)
-