Skip to content
Snippets Groups Projects
  1. Jun 06, 2024
  2. Jun 05, 2024
    • Brad King's avatar
      CPack/WiX: Restore default (missing) InstallScope from 3.28 and lower · 01670894
      Brad King authored
      In commit 60661f67 (CPack/WiX: Make InstallScope configurable,
      2023-11-07, v3.29.0-rc1~413^2) the `CPACK_WIX_INSTALL_SCOPE` default was
      set to `perMachine`.  While installers created with `perMachine` have
      better behavior on their own than installers created without any
      `InstallScope`, they do not cleanly convert existing installations on
      updates.
      
      Fixes: #26029
      01670894
    • Joan Bruguera Micó's avatar
      ctest: Set close-on-exec for jobserver FIFO · ff077af0
      Joan Bruguera Micó authored and Brad King's avatar Brad King committed
      Set the close-on-exec flag to prevent the jobserver FIFO file
      descriptor from leaking to subprocesses spawned by `ctest`.
      
      This leak is usually harmless, but can cause `make test -jN` to hang
      at the end of the build if a test leaves a background process running
      with the jobserver FIFO file descriptor open.
      
      Fixes: #26027
      ff077af0
  3. Jun 03, 2024
  4. May 30, 2024
  5. May 29, 2024
  6. May 28, 2024
  7. May 24, 2024
  8. May 23, 2024
    • Brad King's avatar
      VS: Fix compiler identification of nvcc with unsupported host compiler · 69f26d81
      Brad King authored
      `nvcc` from CUDA < 12.4 does support the MSVC 14.40.17.10 toolset.
      Users may specify `CUDAFLAGS=-allow-unsupported-compiler` to bypass the
      check.  However, we do not use arbitrary user-specified flags during
      compiler identification in the VS generator because escaping them for
      the `AdditionalOptions` of the `.vcxproj` file requires non-trivial
      logic that we currently only implement in the C++ generator code.
      Instead, just always pass `-allow-unsupported-compiler` during CUDA
      compiler identification in the VS generator.
      
      Fixes: #26003
      69f26d81
  9. May 22, 2024
    • Brad King's avatar
      d98df689
    • Brad King's avatar
      libuv: win/spawn: disable extra-file-descriptor support not needed by CMake · a5903828
      Brad King authored
      Upstream libuv supports passing file descriptors >= 3 to child processes
      via `STARTUPINFOW` members reserved by the MSVC C run-time.  However,
      some programs use `GetStartupInfoW` to initialize a `STARTUPINFOW`
      structure to pass to `CreateProcessW` without clearing the reserved
      members.  If we launch such programs with non-zero values in the
      reserved members, the MSVC C run-time in *their* children may not
      correctly associate the stdin/stdout/stderr streams' file descriptors
      with the corresponding `HANDLE`s.
      
      Patch our copy of libuv to avoid using the reserved members.  This
      restores `execute_process` support for the above-described programs as
      we had prior to commit 5420639a (cmExecuteProcessCommand: Replace
      cmsysProcess with cmUVProcessChain, 2023-06-01, v3.28.0-rc1~138^2~8).
      It also enables support for such programs when launched by `ctest`.
      
      Fixes: #25996
      Fixes: #25889
      a5903828
  10. May 17, 2024
  11. May 16, 2024
  12. May 15, 2024
  13. May 14, 2024
  14. May 13, 2024
    • Brad King's avatar
      ExternalProject: Restore support for Xcode with an effective platform · 0a3caf08
      Brad King authored
      Revert commit cabad8a3 (ExternalProject: Always use $<CONFIG> for
      source files, 2023-02-02, v3.27.0-rc1~550^2~3) and restore
      Xcode-specific behavior intentionally preserved by commit c111d440
      (ExternalProject: Express per-config step stamp file paths using CONFIG
      genex, 2022-06-08, v3.24.0-rc1~15^2).  Unfortunately we still do not
      have a test case, so leave a comment to avoid reverting this.
      
      Issue: #23645
      Issue: #23652
      0a3caf08
  15. May 07, 2024
Loading