- Jun 06, 2024
-
-
Brad King authored
01670894 CPack/WiX: Restore default (missing) InstallScope from 3.28 and lower Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !9586
-
Brad King authored
ff077af0 ctest: Set close-on-exec for jobserver FIFO Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !9580
- Jun 05, 2024
-
-
Brad King authored
In commit 60661f67 (CPack/WiX: Make InstallScope configurable, 2023-11-07, v3.29.0-rc1~413^2) the `CPACK_WIX_INSTALL_SCOPE` default was set to `perMachine`. While installers created with `perMachine` have better behavior on their own than installers created without any `InstallScope`, they do not cleanly convert existing installations on updates. Fixes: #26029
-
Set the close-on-exec flag to prevent the jobserver FIFO file descriptor from leaking to subprocesses spawned by `ctest`. This leak is usually harmless, but can cause `make test -jN` to hang at the end of the build if a test leaves a background process running with the jobserver FIFO file descriptor open. Fixes: #26027
-
- Jun 03, 2024
-
-
Brad King authored
- May 30, 2024
-
-
3873574f Help: Update MSVC_VERSION range for VS 17.10's MSVC 14.40 toolset Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !9554
-
- May 29, 2024
-
-
Brad King authored
According to this blog post: * https://devblogs.microsoft.com/cppblog/msvc-toolset-minor-version-number-14-40-in-vs-2022-v17-10/ the 14.40 through 14.49 version range will be used by the v143 toolsets. Fixes: #26015
-
Brad King authored
-
98dd754b KWSys: ConsoleBuf: Fix test case when running under Windows Terminal Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !9553
-
Brad King authored
98dd754b KWSys: ConsoleBuf: Fix test case when running under Windows Terminal Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !9553
-
- May 28, 2024
-
-
Brad King authored
Our test case writes a NUL byte to the console to test its behavior. The behavior of Windows Terminal differs from Windows Console Host (conhost.exe). Detect which of these is in use at runtime and adjust our expected result accordingly.
-
Brad King authored
-
fa8c04b4 Tests/RunCMake/execute_process: Check STARTUPINFOW reserved members d98df689 Merge branch 'libuv-win-process-no-extra-stdio' a5903828 libuv: win/spawn: disable extra-file-descriptor support not needed by CMake Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !9541
-
Brad King authored
a5903828 libuv: win/spawn: disable extra-file-descriptor support not needed by CMake Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !9541
-
- May 24, 2024
-
-
69f26d81 VS: Fix compiler identification of nvcc with unsupported host compiler Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !9546
-
Brad King authored
Verify that `execute_process` launches processes on Windows such that `GetStartupInfoW` in the child does not populate `STARTUPINFOW` members reserved for the MSVC C run-time. Issue: #25996
-
- May 23, 2024
-
-
Brad King authored
`nvcc` from CUDA < 12.4 does support the MSVC 14.40.17.10 toolset. Users may specify `CUDAFLAGS=-allow-unsupported-compiler` to bypass the check. However, we do not use arbitrary user-specified flags during compiler identification in the VS generator because escaping them for the `AdditionalOptions` of the `.vcxproj` file requires non-trivial logic that we currently only implement in the C++ generator code. Instead, just always pass `-allow-unsupported-compiler` during CUDA compiler identification in the VS generator. Fixes: #26003
-
- May 22, 2024
-
-
Brad King authored
-
Brad King authored
Upstream libuv supports passing file descriptors >= 3 to child processes via `STARTUPINFOW` members reserved by the MSVC C run-time. However, some programs use `GetStartupInfoW` to initialize a `STARTUPINFOW` structure to pass to `CreateProcessW` without clearing the reserved members. If we launch such programs with non-zero values in the reserved members, the MSVC C run-time in *their* children may not correctly associate the stdin/stdout/stderr streams' file descriptors with the corresponding `HANDLE`s. Patch our copy of libuv to avoid using the reserved members. This restores `execute_process` support for the above-described programs as we had prior to commit 5420639a (cmExecuteProcessCommand: Replace cmsysProcess with cmUVProcessChain, 2023-06-01, v3.28.0-rc1~138^2~8). It also enables support for such programs when launched by `ctest`. Fixes: #25996 Fixes: #25889
-
- May 17, 2024
-
-
Brad King authored
-
9e2f31ec cmCxxModuleMapper: add a query for the open mode for the modmap Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !9525
-
Brad King authored
9e2f31ec cmCxxModuleMapper: add a query for the open mode for the modmap Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !9525
-
- May 16, 2024
-
-
Ben Boeckel authored
GCC (MinGW) wants to use `\n` on Windows too. Fixes: #25974
-
- May 15, 2024
-
-
Brad King authored
-
c773d5b4 CMP0037: Restore diagnostic message for invalid ALIAS target names Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: buildbot <buildbot@kitware.com> Reviewed-by: Ben Boeckel <ben.boeckel@kitware.com> Merge-request: !9519
-
Brad King authored
c773d5b4 CMP0037: Restore diagnostic message for invalid ALIAS target names Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !9519
-
- May 14, 2024
-
-
Brad King authored
-
0a3caf08 ExternalProject: Restore support for Xcode with an effective platform Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !9517
-
Brad King authored
0a3caf08 ExternalProject: Restore support for Xcode with an effective platform Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !9517
- May 13, 2024
-
-
Brad King authored
Revert commit cabad8a3 (ExternalProject: Always use $<CONFIG> for source files, 2023-02-02, v3.27.0-rc1~550^2~3) and restore Xcode-specific behavior intentionally preserved by commit c111d440 (ExternalProject: Express per-config step stamp file paths using CONFIG genex, 2022-06-08, v3.24.0-rc1~15^2). Unfortunately we still do not have a test case, so leave a comment to avoid reverting this. Issue: #23645 Issue: #23652
-
- May 07, 2024
-
-
Brad King authored
-
Brad King authored
-
6df925b5 cxxmodules: Do not scan sources while testing the compiler Acked-by: Kitware Robot <kwrobot@kitware.com> Reviewed-by: Ben Boeckel <ben.boeckel@kitware.com> Merge-request: !9494
-
Brad King authored
6df925b5 cxxmodules: Do not scan sources while testing the compiler Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !9494