Skip to content
Snippets Groups Projects
  1. Mar 08, 2023
  2. Mar 07, 2023
  3. Mar 03, 2023
  4. Mar 02, 2023
    • Brad King's avatar
      ExternalProject: Restore driving install through build system · 77138752
      Brad King authored
      Revert commit 66b5d51f (ExternalProject: Install CMake projects
      using 'cmake --install', 2022-09-08, v3.25.0-rc1~150^2).
      It changed the ExternalProject install step command from:
      
          cmake --build <dir> --target install --config <cfg>
      
      to:
      
          cmake --install <dir> --config <cfg>
      
      The latter command no longer runs the external project build system
      during the install step.  We could consider using the commands:
      
          cmake --build <dir> --target all --config <cfg>
          cmake --install <dir> --config <cfg>
      
      as the install step, but if `CMAKE_SKIP_INSTALL_ALL_DEPENDENCY` is
      used in the external project, that can change semantics too.
      
      Revert the original change pending further investigation on other ways
      to support its motivating use case.  Add a test covering the
      previously-regressed use case.
      
      Fixes: #24567
      Issue: #23946
      77138752
  5. Feb 17, 2023
  6. Feb 06, 2023
  7. Jan 24, 2023
  8. Jan 23, 2023
  9. Jan 21, 2023
  10. Jan 20, 2023
    • Kefu Chai's avatar
      FindOpenSP: Use pkg-config only as hints for main code path · 3b1c19f0
      Kefu Chai authored and Brad King's avatar Brad King committed
      
      before this change, pkg_check_modules(.. IMPORTED_TARGET GLOBAL)
      is used for creating an imported target from which another imported
      interface library named OpenSP::OpenSP is created. but pkg-config
      does not account for all of CMake's other search behavior controls,
      such as CMAKE_FIND_ROOT_PATH. neither does it export the full path
      with OpenSP_LIBRARY.
      
      after this change, the paths found by pkg-config are only used
      as hints for the find_*() commands. and some cleanup are included:
      
      * be QUIET when calling find_package(PkgConfig ..) and
        pkg_check_modules(..) as they are distracting from user's point of
        view. what matters is the output of find_package_handle_standard_args()
      * parse the version and check for the existance of symbol as long as
        header path is found. because they only use header files.
      * define OpenSP_LIBRARY as long as it exists. this just follows
        the convention. as OpenSP_FOUND implies a valid OpenSP_LIBRARY.
      * wrap and intent multi-line command calls for better readability
      * check OpenSP_FOUND before adding OpenSP::OpenSP, it's more
        idiomatic.
      
      Fixes: #24313
      Signed-off-by: default avatarKefu Chai <tchaikov@gmail.com>
      3b1c19f0
  11. Jan 19, 2023
  12. Jan 17, 2023
  13. Jan 16, 2023
  14. Jan 13, 2023
  15. Jan 12, 2023
Loading