Deprecate vtkObjectFactory::ConstructInstance(const char*)

Removing this method in favor of using
vtkObjectBase::InitializeObjectBase, since it uses a user-supplied string.
This approach has proven fragile with templated classes.

Plus, the method is only a thin wrapper around
vtkDebugLeaks::ConstructClass and doesn't need to be.

Common/Core/vtkObjectFactory.cxx

@@ -70,11 +70,20 @@ vtkObject* vtkObjectFactory::CreateInstance(const char* vtkclassname,
   return 0;
 }
 
-void vtkObjectFactory::ConstructInstance(const char*)
+#ifndef VTK_LEGACY_REMOVE
+void vtkObjectFactory::ConstructInstance(const char *vtkclassname)
 {
   // no-op. Call vtkObjectBase::InitializeObjectBase() from the New()
-  // implementation instead.
+  // implementation instead. That way we ensure that the
+  // registration/deregistration strings match.
+  VTK_LEGACY_REPLACED_BODY(vtkObjectFactory::ConstructInstance, "VTK 7.1",
+                           vtkObjectBase::InitializeObjectBase);
+#ifdef VTK_DEBUG_LEAKS
+  vtkDebugLeaks::ConstructClass(vtkclassname);
+#endif // VTK_DEBUG_LEAKS
+
 }
+#endif // not VTK_LEGACY_REMOVE
 
 // A one time initialization method.
 void vtkObjectFactory::Init()

Common/Core/vtkObjectFactory.h

@@ -66,8 +66,10 @@ public:
   /**
    * No longer used. Call vtkObjectBase::InitializeObjectBase() from the
    * New() implementation instead.
+   * @deprecated because this method relies on taking an arbitrary string,
+   * which may not match the GetClassName() string (especially for templates).
    */
-  static void ConstructInstance(const char* vtkclassname);
+  VTK_LEGACY(static void ConstructInstance(const char* vtkclassname));
 
   /**
    * Create all possible instances of the named vtk object.