- Sep 30, 2019
-
-
Brad King authored
Merge-request: !3863
-
Brad King authored
-
Brad King authored
The "all" target in each directory is supposed to have targets from that directory even if the directory itself is marked `EXCLUDE_FROM_ALL` in its parent. This was broken by commit dc688857 (Pass EXCLUDE_FROM_ALL from directory to targets, 2019-01-15, v3.14.0-rc1~83^2) which made the participation of a target in "all" independent of context. Revert much of the logic change from that commit to restore the old behavior. Then re-implement the behavior intended by the commit to keep its test working. Extend the test to cover the old behavior too. Fixes: #19753
- Sep 26, 2019
- Sep 24, 2019
-
-
Brad King authored
-
- Jul 16, 2019
-
- Jul 12, 2019
-
-
Brad King authored
Merge-request: !3549
-
Now that the working directory is in the build tree, relative input paths must be converted to an absolute path to remain relative to the source directory. Fixes: #19472
-
- Jul 09, 2019
- Jun 19, 2019
-
-
Brad King authored
Merge-request: !3459
-
In commit c4b4d8b3 (POSITION_INDEPENDENT_CODE: Manage link flags for executables, 2018-10-02, v3.14.0-rc1~395^2) we accidentally removed our Android-specific logic for PIE under the CMP0083 OLD behavior. Restore it and also implement Android-specific logic for CMP0083 NEW behavior. Fixes: #19393
-
- May 31, 2019
-
- May 30, 2019
-
-
Brad King authored
Merge-request: !3388
-
Avoid listing the same input more than once in custom commands generated in `.vcxproj` and `.csproj` files. In the case of a `.vcxproj` file additionally avoid listing the source to which the command is attached since it is already implicitly a dependency. This is a nice cleanup and also works around a VS 2019 16.1 regression in MSBuild dependency checking. Starting with that version, MSBuild now re-builds custom commands when the list of dependencies has changed. However, its check is confused by duplicate dependencies. De-duplicating them avoids this problem. Co-Author: Brad King <brad.king@kitware.com> Fixes: #19303
-
-
Brad King authored
-
Brad King authored
Merge-request: !3395
-
Brad King authored
Entries of the `CPATH` environment variable are implicitly searched as include directories by some C/C++ compilers. Since commit 5990ecb7 (Compute implicit include directories from compiler output, 2018-12-07, v3.14.0-rc1~108^2) these entries are detected by CMake and included in the `CMAKE_{C,CXX}_IMPLICIT_INCLUDE_DIRECTORIES` variables. However, we should not exclude them from explicit specification via `-I` or particularly `-isystem` because they are meant as user-specified include directories that can be re-ordered without breaking compiler builtin headers. In particular, we need explicit requests via `include_directories` with the `SYSTEM` option to result in `-isystem` so that third-party headers do not produce warnings. Co-Author: Ben Boeckel <ben.boeckel@kitware.com> Fixes: #19291
-
- May 28, 2019
-
-
Brad King authored
Merge-request: !3391
-
- May 24, 2019
-
-
Brad King authored
Merge-request: !3368
-
-
- May 21, 2019
- May 14, 2019
- May 13, 2019
- May 11, 2019
-
-
Gregor Jasny authored
Closes: #19172
-
- May 06, 2019
-
-
Brad King authored
Merge-request: !3283
-
Brad King authored
Merge-request: !3287
-
Brad King authored
Merge-request: !3272
-
When building for iOS, the compiled target is placed into a bundle. If a single-configuration generator is used, like Makefiles or Ninja, the try_compile FILE_COPY behavior fails to find the bundle, because it only looks for the bundle inside a Debug subfolder (presumably to support a multi-configuration generator like Xcode). Consider looking for the bundle in the root try_compile folder, as well as in the location specified by CMAKE_TRY_COMPILE_CONFIGURATION. Closes: #19211
-