Skip to content
Snippets Groups Projects
  1. Mar 16, 2018
  2. Mar 15, 2018
    • Brad King's avatar
      Merge branch 'gtest_discover_tests_timeout' into release-3.10 · aa41fa90
      Brad King authored
      Merge-request: !1851
      aa41fa90
    • Craig Scott's avatar
      GoogleTest: Rename TIMEOUT parameter to avoid clash · 96fdde26
      Craig Scott authored and Brad King's avatar Brad King committed
      In gtest_discover_tests(), the TIMEOUT keyword was making it
      impossible to set the TIMEOUT test property via the PROPERTIES
      keyword. This would be a frequent case, but it doesn't complain
      and instead silently does something different to what would
      normally be expected. The TIMEOUT keyword has been renamed
      to DISCOVERY_TIMEOUT, thereby removing the clash.
      
      This is a breaking change. 3.10.1 and 3.10.2 were the only versions
      that supported the TIMEOUT keyword and uses of it were likely
      not working as intended.
      
      Fixes: #17801
      96fdde26
  3. Mar 13, 2018
  4. Mar 09, 2018
  5. Jan 18, 2018
  6. Jan 10, 2018
    • Brad King's avatar
      Merge branch 'backport-autogen-nexist-source-fix' into release-3.10 · ecfc729a
      Brad King authored
      Merge-request: !1650
      ecfc729a
    • Sebastian Holtermann's avatar
      Autogen: Ignore not existing source files in cmMakefile · d592bfc9
      Sebastian Holtermann authored
      Until CMake 3.10 a list of source files that had the AUTOUIC_OPTIONS property
      populated was kept in `cmMakefile::QtUiFilesWithOptions`.  In the process to
      remove all AUTOUIC related code from `cmMakefile` for CMake 3.10, the pre
      filtered list was replaced by a loop in `cmQtAutoGeneratorInitializer` over
      all source files in the `cmMakefile`.  This loop introduced the problem that
      file paths were computed for source files that weren't in the target's sources
      and that might not even have existed.  If the path for an unused and not
      existing file was computed a `cmake::FATAL_ERROR` with the error message
      "Cannot find source file:" was thrown nevertheless.
      This caused some projects to fail in CMake 3.10.
      
      This patch adds a test for path errors in the loops in
      `cmQtAutoGeneratorInitializer` that iterate over all source files in a
      `cmMakefile`. If a path error appears, the file is silently ignored.
      If the file is part of the target's sources, the path error will still be
      caught in the loop over all the target's sources.
      
      This is the fix for CMake 3.10.1.
      d592bfc9
  7. Jan 09, 2018
  8. Dec 20, 2017
  9. Dec 14, 2017
  10. Dec 13, 2017
  11. Dec 12, 2017
  12. Dec 08, 2017
  13. Dec 07, 2017
  14. Dec 06, 2017
    • Brad King's avatar
      Merge branch 'backport-revert-server-target-backtraces' into release-3.10 · 05f86af7
      Brad King authored
      Merge-request: !1564
      05f86af7
    • Brad King's avatar
      server: Revert "Report backtraces in codemodel response" · 8b2736c7
      Brad King authored
      The backtrace information is very repetitive and hugely increases the
      size of the codemodel object.  We need to remove it until an alternative
      representation can be developed.  Revert commit v3.10.0-rc1~393^2
      (server: Report backtraces in codemodel response, 2017-06-20), except
      for the protocol version number (because it indicates other new things).
      
      Unfortunately this is incompatible with clients that expect the
      "crossReferences" field in targets.  However, the regression in memory
      usage is quite serious, especially on large projects, and therefore
      breaks even older clients that do not use backtraces.  Since the
      "crossReferences" field was only provided by one release (3.10.0), it is
      simplest to revert it outright for 3.10.1.
      
      Fixes: #17502
      8b2736c7
    • Matthew Woehlke's avatar
      GoogleTest: Add test for missing test executable · 935848a8
      Matthew Woehlke authored and Brad King's avatar Brad King committed
      Add a test to verify expected behavior when a test executable on which
      gtest_discover_tests is invoked was not built. (The test for the newly
      added timeout conveniently sets up this situation, so this new test was
      almost trivial to add.)
      935848a8
    • Matthew Woehlke's avatar
      GoogleTest: Add timeout to discovery · 29731d89
      Matthew Woehlke authored and Brad King's avatar Brad King committed
      Add a TIMEOUT option to gtest_discover_tests. This provides a
      work-around in case a test goes out to lunch, rather than causing the
      build to simply hang. (Although this is still a problem with the user's
      project, hanging the build is not cool, especially in the case of
      automatically running CI builds. It is much preferred that the build
      should actively fail in this case, and it is trivially easy for us to
      implement that.)
      29731d89
  15. Dec 05, 2017
    • Brad King's avatar
      Merge branch 'findmpi-notfound-spam' into release-3.10 · 0418e91f
      Brad King authored
      Merge-request: !1557
      0418e91f
    • Brad King's avatar
      Merge branch 'findmpi-found-cond' into release-3.10 · 64184762
      Brad King authored
      Merge-request: !1556
      64184762
    • Christian Pfeiffer's avatar
      FindMPI: Fix multiple configure runs · 2047eb36
      Christian Pfeiffer authored
      Due to a erroneous logical dependency on a temporary variable, FindMPI
      would depend its FOUND status on the set of flags needed to support
      compiler-implicit MPI support after the first configure run.
      
      This behavior is especially causing a misreported NOT FOUND status after
      the first run on MPI implementations without MPI compiler like MS-MPI or
      MPICH2 on Windows.
      2047eb36
    • Christian Pfeiffer's avatar
      FindMPI: Correct legacy variable handling · bde7513d
      Christian Pfeiffer authored
      Due to a minor logic error, MPI_LIBRARY, MPI_EXTRA_LIBRARY and
      MPI_<LANG>_LIBRARIES hints are currently not correctly handled and
      discarded.
      
      Additionally, if either C or CXX aren't enabled, there subsequent calls
      to FindMPI will cause cache variables of the sort "MPI_MPI_EXTRA_LIBRARY-NOTFOUND"
      to appear due to an error in the compatibility handling. (Doesn't affect
      functionality)
      bde7513d
  16. Dec 01, 2017
Loading