The input is the number of bits, so allocate that many output elements.
Previously, at most 7 elements would be made for the output.

Discovered by `clang-tidy`.

The wrong variable name was used when requesting the module.

Sean McBride authored 2 years ago and Kitware Robot committed 2 years ago

f4b47dbe Replaced many sprintf uses with safer snprintf

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Ben Boeckel <ben.boeckel@kitware.com>
Reviewed-by: David Gobbi <david.gobbi@gmail.com>
Merge-request: !9294

Sean McBride authored 2 years ago and Kitware Robot committed 2 years ago

5d6eacad Fixed link error building with Xcode 8.2.1

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Ben Boeckel <ben.boeckel@kitware.com>
Merge-request: !9334

Ben Boeckel authored 2 years ago and Kitware Robot committed 2 years ago

2ccdae98 typos: fix `nothin` slang usage
d2d9f7d4 warnings: remove usage of `std::binary_function`
a3d59cde vtkCGNSReader: remove dead code
821f8f53 vtkPLagrangianParticleTracker: ensure that source and size are initialized
454fc734 vtkPythonInterpreter: use `size_t` to iterate over a vector
2945af89 vtkDistanceRepresentation3D: simplify conditional
f66efa90 vtkHyperTreeGridPProbeFilter: avoid shadowing
40bfdfac vtkm: return handle by move in DataArrayConverters
...

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !9330

Ben Boeckel authored 2 years ago and Kitware Robot committed 2 years ago

736b4082 std::swap: use `std::swap` instead of manual macro implementations

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !9325

Sujin Philip authored 2 years ago and Kitware Robot committed 2 years ago

0d9fdb0b Increase the timeout for `fedora34-tidy`
9419e060 Suppress tidy warning `modernize-use-equals-default`

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !9328

David Gobbi authored 2 years ago and Kitware Robot committed 2 years ago

5196a595 Update the ref to vtkDICOM remote module

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !9324

David Gobbi authored 2 years ago and Kitware Robot committed 2 years ago

5196a595 Update the ref to vtkDICOM remote module

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !9324

Mathieu Westphal (Kitware) authored 2 years ago and Kitware Robot committed 2 years ago

d04a2187 ci: don't mask failing targets
51da08a8 gitlab-ci: show a warning in the pipeline when detected

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Timothee Chabat <timothee.chabat@kitware.com>
Acked-by: Ben Boeckel <ben.boeckel@kitware.com>
Merge-request: !9288

Thomas Galland authored 2 years ago and Kitware Robot committed 2 years ago

c3ec685a Uniformize vtkPlot API

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !9320

David Gobbi authored 2 years ago and Kitware Robot committed 2 years ago

ee2c9bff Properly wrap array reference parameters

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Charles Gueunet <charles.gueunet@kitware.com>
Merge-request: !9331

If multiple targets are built, any breaking should fail the build, so
stop when any of them fail. Otherwise a further target that passes would
mask the prior failure.

The build is frequently timing out.

We don't use `= default` in certain VTK-m based code as `nvcc` does not
allow it and produces the following warning:

"__deviceddd__/__host__ annotation is ignored on a function that is explicitly defaulted on its first declaration"

Sean McBride authored 2 years ago and Kitware Robot committed 2 years ago

6edc5f80 Fixed more warnings from cdash

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !9297

Spiros Tsalikis authored 2 years ago and Kitware Robot committed 2 years ago

b608770c Common/DataModel/Testing: avoid ODR violations of helper functions

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Ben Boeckel <ben.boeckel@kitware.com>
Merge-request: !9333

Spiros Tsalikis authored 2 years ago and Kitware Robot committed 2 years ago

b608770c Common/DataModel/Testing: avoid ODR violations of helper functions

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Ben Boeckel <ben.boeckel@kitware.com>
Merge-request: !9333

Specifically, fixes:

/Common/DataModel/vtkDataSet.cxx:1075:44: warning: constructor parameter 'BitSet' shadows the field 'BitSet' of 'IsAnyBitSetFunctor' [-Wshadow-field-in-constructor]
  IsAnyBitSetFunctor(vtkUnsignedCharArray* BitSet, int BitFlag)
                                           ^
/Common/DataModel/vtkDataSet.cxx:1075:56: warning: constructor parameter 'BitFlag' shadows the field 'BitFlag' of 'IsAnyBitSetFunctor' [-Wshadow-field-in-constructor]
  IsAnyBitSetFunctor(vtkUnsignedCharArray* BitSet, int BitFlag)

/Filters/General/vtkFiniteElementFieldDistributor.cxx:819:43: warning: comparison of integers of different signs: 'std::vector<std::vector<double>>::size_type' (aka 'unsigned long') and 'const int' [-Wsign-compare]
        reqInit |= (*hCurlMats)[i].size() != npts;
                   ~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~
/Filters/General/vtkFiniteElementFieldDistributor.cxx:820:42: warning: comparison of integers of different signs: 'std::vector<std::vector<double>>::size_type' (aka 'unsigned long') and 'const int' [-Wsign-compare]
        reqInit |= (*hDivMats)[i].size() != npts;
                   ~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~

/Filters/General/vtkFiniteElementFieldDistributor.cxx:1513:16: warning: moving a temporary object prevents copy elision [-Wpessimizing-move]
      coeffs = std::move(::GetEdgeAttributes(fieldName, oldCd, cellId));
               ^

/Filters/General/vtkFiniteElementFieldDistributor.cxx:1517:16: warning: moving a temporary object prevents copy elision [-Wpessimizing-move]
      coeffs = std::move(::GetFaceAttributes(fieldName, oldCd, cellId));
               ^

/IO/IOSS/vtkIOSSReader.cxx:192:26: warning: unused function 'Split' [-Wunused-function]

/Charts/Core/vtkChartParallelCoordinates.cxx:230:27: warning: comparison of integers of different signs: 'int' and 'std::vector<std::vector<float>>::size_type' (aka 'unsigned long') [-Wsign-compare]

/IO/Cesium3DTiles/TreeInformation.cxx:613:92: warning: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long') [-Wsign-compare]

/IO/Cesium3DTiles/TreeInformation.cxx:659:21: warning: comparison of integers of different signs: 'int' and 'std::vector<std::vector<unsigned long>>::size_type' (aka 'unsigned long') [-Wsign-compare]

/IO/Cesium3DTiles/TreeInformation.cxx:661:23: warning: comparison of integers of different signs: 'int' and 'std::vector<unsigned long>::size_type' (aka 'unsigned long') [-Wsign-compare]

/Rendering/Volume/Testing/Cxx/TestGPURayCastMapperShadows.cxx:46:20: warning: unused function 'idxToCoords' [-Wunused-function]

/Filters/Geometry/vtkGeometryFilter.cxx:2104:7: warning: field 'Strips' will be initialized after field 'VertsConnPtr' [-Wreorder-ctor]

/Charts/Core/vtkChartParallelCoordinates.cxx:234:23: warning: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long') [-Wsign-compare]

/Common/DataModel/vtkCellTreeLocator.cxx:315:9: warning: field 'Cnt' will be initialized after field 'Min' [-Wreorder-ctor]

/Common/DataModel/vtkCellTreeLocator.cxx:1227:22: warning: comparison of integers of different signs: 'int' and 'std::vector<std::pair<vtkBoundingBox, int>>::size_type' (aka 'unsigned long') [-Wsign-compare]

/IO/IOSS/vtkIOSSWriter.cxx:62:18: warning: private field 'Self' is not used [-Wunused-private-field]

/IO/IOSS/vtkIOSSModel.cxx:780:24: warning: loop variable 'tuple' binds to a temporary value produced by a range of type 'typename detail::SelectTupleRange<vtkIntArray *, 0>::type' (aka 'vtk::detail::TupleRange<vtkAOSDataArrayTemplate<int>, 0>') [-Wrange-loop-bind-reference]

Gaspard Thevenon authored 2 years ago and Kitware Robot committed 2 years ago

c4874d9b Replace vtkOpenGLRenderWindow noise texture by blue noise

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !9327

Error was:

```
Undefined symbols for architecture x86_64:
  "vtkProbeFilter::ProbeEmptyPointsWorklet::SnappingRadius", referenced from:
      vtkProbeFilter::ProbeEmptyPointsWorklet::operator()(long long, long long) in vtkProbeFilter.cxx.o
```

Found by GCC 12.

Fixes: #18581