Jens Munk Hansen authored 2 months ago and Lucas Givord committed 1 month ago

(cherry picked from commit 9b89398b)

Sankhesh Jhaveri authored 9 months ago and Lucas Givord committed 1 month ago

This change ensures that the camera orientation widget handles are
updated at build time. This allows arbitary calls to BuildRepresentation
to yield updated handles.

(cherry picked from commit 8bad31f2)

The member operator can be used if it is `const` qualified.

This avoids running any logic if the value doesn't actually change
because it was clamped to the current value.

Also port to using `std::max` and `std::min` at the same time.

- the webgpu classes should not use them because Marshalling
  is currently not enabled for the VTK::RenderingWebGPU module.

- closes vtk/vtk#19592

Allows for custom manipulations for the contour representation subclasses.

Nicolas Vuaille authored 2 months ago and Spiros Tsalikis committed 2 months ago

!11708 introduced the vtkBoundedWidgetRepresentation to handle widget
outlines, an existing but duplicated feature. The refactor misses a
point: when OutsideBounds is off and ConstrainToWidgetBounds is On,
the box should be translated and not inflated to stays around the center.

This was not detected due to bad threshold in baseline comparison.
CylinderWidget2 and PlaneWidget3 were impacted.

Nicolas Vuaille authored 2 months ago and Spiros Tsalikis committed 2 months ago

Leftover from !11708: we changed the picker used
for some interactions (as for the Radius), so the widget
correctly follows the cursor. Obviously, this impacts
the test final screenshot. But a wrong threshold in baseline
comparison used to hide it.
See !11714 for threshold update.

Nicolas Vuaille authored 2 months ago and Spiros Tsalikis committed 2 months ago

Using position instead of motion avoids shifts.
Also widget actually follow the cursor, which is more
intuitive

ee7301ba changed the log
but did not update the baseline.

In cb5e1bbf the plane
colors changed from ambient to solid.

The content is correct, but the rendering of edges have
slightly changed.

When vtkContourRepresentation::ClearAllNodes is invoked, it frees up
some default internal ivars. This change ensures that those ivars are
reset so that the representation can be reused with a different set of
node points.

This change ensures that the camera orientation widget handles are
updated at build time. This allows arbitary calls to BuildRepresentation
to yield updated handles.

Fix two warnings introduced by
c446f2bc.

Different implicit representations implement a "crop at outline" feature,
where the drawn widget is clipped by a bounding box composed
of the input data bounding box extended to contain widget Origin.

This factorizes this feature.
We use inheritance and intermediate class (vtkBoundedWidgetRepresentation),
to limit API evolution of concrete vtkImplicitXXXRepresentation.

Ported classes: vtkImplicitConeRepresentation,
vtkImplicitCylinderRepresentation, vtkImplicitAnnulusRepresentation
vtkImplicitPlaneRepresentation

Newly supported class: vtkImplicitFrustumRepresentation
(it was using a fixed size, instead of dynamic one)

Also, the useful part of the motion is the projection on the
main axis. Use that instead of motion magnitude.

Setter should not modify values.

Clamping the radius in its setter forces the user to set Inner and Outer
in the correct order. Prefer accepting any value, and do some
sanity check when using them.

Check that annulus circle follows mouse position

Using actual position to compute radius helps with interaction:
widget stays under the mouse in a predictable way.

Previous code makes use of motion in Y direction of DisplayCoordinates,
which was harder to understand.

See also: #19537

We have 2 pickers: one for some handles, another for
the drawn widget. Depending on the interaction, using
the corresponding one gives better result when computing
WorldCoordinates.

This code doesn't fit the usage of the VTK_DEPRECATED_IN_X_Y_Z()
macros, but we still want to eventually remove it, so we are
marking it to be removed when deprecated-in-9.5.0 code is removed.

- Lift the member variables from composite polydata mapper to the base class (vtkPolyDataMapper)