This avoids running any logic if the value doesn't actually change
because it was clamped to the current value.

Also port to using `std::max` and `std::min` at the same time.

Clamping in the condition and again in the assignment is just
error-prone. Clamp once and store the result.

If the angle is different, but ends up being clamped to the current
value, an unnecessary `Modified` event is generated.

Louis Gombert authored 1 month ago and Kitware Robot committed 1 month ago

ede4100a IOSS: test 2D cell arrays that should be 3D
e9852681 IOSS: Read all 2D vectors as 3D

Acked-by: Kitware Robot <kwrobot@kitware.com>
Tested-by: buildbot <buildbot@kitware.com>
Reviewed-by: Nicolas Vuaille <nicolas.vuaille@kitware.com>
Reviewed-by: Mathieu Westphal (Kitware) <mathieu.westphal@kitware.com>
Merge-request: !11876

Vicente Bolea authored 1 month ago and Kitware Robot committed 1 month ago

d1c8ccbd ci: enable one java build for mr pipelines

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Reviewed-by: Mathieu Westphal (Kitware) <mathieu.westphal@kitware.com>
Merge-request: !11830

Mathieu Westphal (Kitware) authored 1 month ago and Kitware Robot committed 1 month ago

7655d4a3 Simplify loop
a69dd97a move allocation out of cell loop
da9087d4 use dedicated VTK_POLYHEDRON cell API

Acked-by: Kitware Robot <kwrobot@kitware.com>
Tested-by: buildbot <buildbot@kitware.com>
Reviewed-by: Mathieu Westphal (Kitware) <mathieu.westphal@kitware.com>
Reviewed-by: Arthur P. <arthurpiquet@gmail.com>
Merge-request: !11868

Jean Fechter authored 1 month ago and Kitware Robot committed 1 month ago

493b91c0 Add test for polar axes with no data
acd3a1d8 Unitialize vtkPolarAxesActor bounds to allow smaller bounds in client/server

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Reviewed-by: Mathieu Westphal (Kitware) <mathieu.westphal@kitware.com>
Reviewed-by: Nicolas Vuaille <nicolas.vuaille@kitware.com>
Merge-request: !11883

3D vectors are much better handled by VTK and ParaView, especially for the glyph filter. Now, all 2D vector fields are read as 3D, with a null 3rd component. This behavior was already implemented in the legacy exodus reader.

Mathieu Westphal (Kitware) authored 1 month ago and Kitware Robot committed 1 month ago

f6466b06 Deprecate vtkHierarchicalBoxDataSet and friends

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Reviewed-by: Nicolas Vuaille <nicolas.vuaille@kitware.com>
Reviewed-by: Spiros Tsalikis <spiros.tsalikis@kitware.com>
Merge-request: !11862

Louis Gombert authored 1 month ago and Kitware Robot committed 1 month ago

48bb860a wasm build instructions update

Acked-by: Kitware Robot <kwrobot@kitware.com>
Tested-by: buildbot <buildbot@kitware.com>
Reviewed-by: Lucas Givord <lucas.givord@kitware.com>
Reviewed-by: Jules Bourdais <jules.bourdais@kitware.com>
Merge-request: !11875

Jaswant Panchumarti (Kitware) authored 1 month ago and Kitware Robot committed 1 month ago

2d4565f2 clean up VTK_MARSHAL macro usage
59320947 Fix vtkWebGPUActor::ShallowCopy runtime error
71a3a700 wasm: enable exception support for exprtk
2cd926af Add vtkWebGPUGlyph3DMapper

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Merge-request: !11750

David Gobbi authored 1 month ago and Kitware Robot committed 1 month ago

9c73c5cc Fix clang-19 build error for CellGridReader

Acked-by: Kitware Robot <kwrobot@kitware.com>
Tested-by: buildbot <buildbot@kitware.com>
Reviewed-by: Jaswant Panchumarti (Kitware) <jaswant.panchumarti@kitware.com>
Merge-request: !11873

Jaswant Panchumarti (Kitware) authored 1 month ago and Kitware Robot committed 1 month ago

ba5fefbf Merge branch 'upstream-cgns' into tpl-cgns-4.5.0
a9c877fc cgns 2025-01-24 (52413bd3)
0f09af11 cgns: update vendored version to 4.5.0

Acked-by: Kitware Robot <kwrobot@kitware.com>
Tested-by: buildbot <buildbot@kitware.com>
Reviewed-by: Cory Quammen <cory.quammen@kitware.com>
Acked-by: Mickael PHILIT <mickey.phy@gmail.com>
Merge-request: !11871

- the webgpu classes should not use them because Marshalling
  is currently not enabled for the VTK::RenderingWebGPU module.

- This commit implements the shallow copy function in vtkWebGPUActor
  to assign the bindgroup, bindgroup layout and actor buffer.
- It also adds a placeholder object factory override for
  vtkShaderProperty to silence the runtime error from
vtkProp::ShallowCopy where it tries to instantiate an abstract
vtkShaderProperty class.
- The webgpu shader property is currently empty because it does not
yet make sense to provide users with functionality to replace shader
code or pass custom buffers when the polydata mapper is not compatible
with such patterns.

- `TestGlyph3DMapperOrientationArray` uses vtkArrayCalculator
which internally uses exprtk. This test threw an uncaught exception
from exprtk because in wasm, exceptions are not enabled by default.
- This commit enables exception support when compiling the exprtk
library with emscripten. The exception support is not enabled
for all targets yet because the emscripten docs say this flag
has a large overhead in performance.

- The vtkWebGPUGlyph3DMapper implements the abstract vtkGlyph3DMapper using webgpu.
- It follows a similar approach as the opengl glyph 3d mapper by using instanced rendering to repeatedly render the source geometry at point locations in the input dataset.

Mathieu Westphal (Kitware) authored 1 month ago and Kitware Robot committed 1 month ago

f9bb9e1a basic use of new VTK_POLYHEDRON API

Acked-by: Kitware Robot <kwrobot@kitware.com>
Tested-by: buildbot <buildbot@kitware.com>
Reviewed-by: Mathieu Westphal (Kitware) <mathieu.westphal@kitware.com>
Merge-request: !11877

Jaswant Panchumarti (Kitware) authored 1 month ago and Kitware Robot committed 1 month ago

1c617ee5 Fix bug with removing and adding a new vtkOrientationMarkerWidget

Acked-by: Kitware Robot <kwrobot@kitware.com>
Tested-by: buildbot <buildbot@kitware.com>
Reviewed-by: Sebastien Jourdain <sebastien.jourdain@kitware.com>
Merge-request: !11874

Ben Boeckel authored 1 month ago and Kitware Robot committed 1 month ago

71b650e7 vtkModuleWrapPython: support depending on modules being wrapped

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Tested-by: David Gobbi <david.gobbi@gmail.com>
Merge-request: !11872

The `TARGET` argument is an `INTERFACE` library which does not end up in
the build graph as something that can be requested of `make` or `ninja`
or works as a dependency of a custom target. Instead, make a custom
target that can be requested at build time by the user and depended upon
by other custom targets in the build.

- closes #19592

# By cgns Upstream
* upstream-cgns:
  cgns 2025-01-24 (52413bd3)