Ben Boeckel authored 1 month ago and Kitware Robot committed 1 month ago

fc259aec Testing/Core: convert file to Unix line endings
b150d9c0 sources: remove trailing whitespace
cdc440e4 glsl: remove trailing whitespace
4a3d904b cmake: remove trailing whitespace
f72780b1 vtkTestingRenderingDriver: fix indentation of template code
0dad147b vtkVolumeRayCastSpaceLeapingImageFilter: fix some whitespace
03f1014a vtkValueFromString: fix typo in macro name
d8d964bd typos: fix typos in comments

Acked-by: Kitware Robot <kwrobot@kitware.com>
Tested-by: buildbot <buildbot@kitware.com>
Reviewed-by: Ryan Krattiger <ryan.krattiger@kitware.com>
Merge-request: !11891

Sean McBride authored 1 month ago and Kitware Robot committed 1 month ago

a7d8dd25 Eliminate (semantically) a repeated search in RemoveViewProp
6a5b11dc Removed unneeded call to MakeCurrent()

Acked-by: Kitware Robot <kwrobot@kitware.com>
Tested-by: buildbot <buildbot@kitware.com>
Merge-request: !11657

Jaswant Panchumarti (Kitware) authored 1 month ago and Kitware Robot committed 1 month ago

1431d88c webgpu: fix lighting for lines and points
2989712d Remove internal vtkWebGPUPolyDataMapper::GetNeedToRemapScalars
56421b68 Fix RemoveViewProp() in webgpu renderer
1f89fddc Add TestRemoveActors in webgpu module
b17a0222 webgpu: use raw pointer instead of vtkWeakPointer
9a053a8b webgpu: fetch scalars only when necessary
8c0b3014 Remove warning macro in vtkWebGPUPolyDataMapper::CreateTopologyBindGroup

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Merge-request: !11917

Replaced HasViewProp() call with IndexOfFirstOccurence(), the former is just a thin wrapper of the latter anyway.

This way we can call the other variant of RemoveItem(), the one that takes the index instead of the prop itself.

With the current implementation of RemoveItem, this doesn't help much, but eventually can, as now it doesn't have to search for the prop *again*.

RemoveAllViewProps doesn't call MakeCurrent(), so presumably RemoveViewProp doesn't need to either.

Ben Boeckel authored 1 month ago and Kitware Robot committed 1 month ago

2e210c2a WebGPU: remove Metal conditionals
b3832cc4 WebGPU: remove unnecessary comment
e70ef91e Rendering/WebGPU: set `VTK_HAVE_XCURSOR` on the right file
9d496596 Rendering/UI: remove unused variable usage
bf1d9b22 Examples: fix some style nits
fd5766a9 cmake: fix whitespace nits in WebGPU code

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Reviewed-by: Jaswant Panchumarti (Kitware) <jaswant.panchumarti@kitware.com>
Merge-request: !10127

- enables lighting only when interpolation type is not flat and shader is rendering tubes or spheres.
- this logic is similar to vtkOpenGLPolyDataMapper
- updated the layout of ShadeOptions struct in vtkWebGPUActor with new InterpolationType
  member which can be one of VTK_FLAT, VTK_GOURAUD, VTK_PHONG or VTK_PBR. The shaders
  only implement VTK_FLAT for now.

- vtkMapper::MapScalars already checks mtime and updates the mapped
scalars if necessary.

- when a prop is removed, invalidate the render bundle.
- since the bundle is invalidated outside the `DeviceRender` call,
  modify the `InvalidateBundle` function to also reset `Bundle` to null

- This commit includes an optimization for large number of blocks or actors
  O(10,000) and higher.
- It gives a 10x performance boost. Previously, rendering 10,000 actors
  or 10,000 blocks in one actor with composite mapper took ~200 milliseconds
  per frame.
- With this commit, it only takes 20-25 ms per frame.
- The mapper's internal cache of actors is queried in every `RenderPiece`.
  During the query, when constructing a key for the `map::find`,
  the constructor and destructor of the vtkWeakPointer from a raw
  pointer took up roughly 50-60ms when repeated over O(10,000) actors

Mathieu Westphal (Kitware) authored 1 month ago and Kitware Robot committed 1 month ago

66c84158 Add changelog
2e41f8a4 Add test for HTG FillMaterial
40ba507a Add FillMaterial option to HTG geometry filter

Acked-by: Kitware Robot <kwrobot@kitware.com>
Rejected-by: buildbot <buildbot@kitware.com>
Merge-request: !11915

Lucas Gandel authored 1 month ago and Kitware Robot committed 1 month ago

d0bb8ff6 Allow specifying a custom path to look for controller models
b7c8f2b0 Allow users to define a custom directory to look for RemotingXR.json

Acked-by: Kitware Robot <kwrobot@kitware.com>
Tested-by: buildbot <buildbot@kitware.com>
Reviewed-by: Lucas Givord <lucas.givord@kitware.com>
Merge-request: !11918

Spiros Tsalikis authored 1 month ago and Kitware Robot committed 1 month ago

bec2b177 Eliminate unused-local-typedefs warnings
c3aea0a5 Eliminate readability-container-data-pointer warnings
c2bd8410 Eliminate modernize-use-transparent-functors warnings
6b7ee14c Eliminate modernize-avoid-bind warnings
1733ea9d Remove GCC 4.8.5 references
a7b37a68 Add changelog
9926e161 vtkTypedDataArray & vtkTypedDataArrayIterator: Deprecate
e236463e vtkMappedDataArray: Deprecate
...

Acked-by: Kitware Robot <kwrobot@kitware.com>
Tested-by: buildbot <buildbot@kitware.com>
Merge-request: !11907