Merge topic 'plug-an-valueindexed-material-memleak' into release

7e6648f6 plug a bad memory leak with value indexed materials

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Michael Migliore <michael.migliore@kitware.com>
Merge-request: !6553

Rendering/RayTracing/vtkOSPRayMaterialHelpers.cxx

@@ -306,6 +306,7 @@ OSPMaterial vtkOSPRayMaterialHelpers::MakeMaterial(
             vtkImageData* vColorTextureMap = vtkImageData::SafeDownCast(texname->GetInput());
             OSPTexture t2d = vtkOSPRayMaterialHelpers::VTKToOSPTexture(backend, vColorTextureMap);
             ospSetObject(oMaterial, param.first.c_str(), static_cast<OSPTexture>(t2d));
+            ospRelease(t2d);
           }
         }
         break;

Rendering/RayTracing/vtkOSPRayPolyDataMapperNode.cxx

@@ -629,7 +629,8 @@ OSPMaterial MakeActorMaterial(vtkOSPRayRendererNode* orn, OSPRenderer oRenderer,
   {
     if (std::string("Value Indexed") == property->GetMaterialName())
     {
-      vtkOSPRayMaterialHelpers::MakeMaterials(orn, oRenderer, mats);
+      vtkOSPRayMaterialHelpers::MakeMaterials(
+        orn, oRenderer, mats); // todo: do an mtime check to avoid doing this when unchanged
       std::string requested_mat_name = materialName;
       if (requested_mat_name != "" && requested_mat_name != "Value Indexed")
       {