Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
VTK
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Spiros Tsalikis
VTK
Commits
27f2fd11
Commit
27f2fd11
authored
2 months ago
by
Jaswant Panchumarti (Kitware)
Browse files
Options
Downloads
Patches
Plain Diff
Document removal of nlohmannjson from CommonCore public API
parent
88656d5e
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
Common/Core/vtkAbstractArray.h
+7
-0
7 additions, 0 deletions
Common/Core/vtkAbstractArray.h
Documentation/release/dev/breaking-change-remove-nlohmann-json-from-public-API.md
+7
-0
7 additions, 0 deletions
...v/breaking-change-remove-nlohmann-json-from-public-API.md
with
14 additions
and
0 deletions
Common/Core/vtkAbstractArray.h
+
7
−
0
View file @
27f2fd11
...
...
@@ -45,6 +45,13 @@
* Unless `Modified` is called, various cached entities, like array range,
* map created for `LookupValue` may become obsolete and yield incorrect results.
*
* @warning
* In VTK 9.4, new method `nlohmann::json vtkAbstractArray::SerializeValues()` was
* introduced which required exposing symbols from
* VTK::nlohmannjson library in public API. This method will be removed in VTK 9.5 as it caused
* difficulty for downstream projects that linked to a different nlohmannjson. It cannot be
* deprecated because doing so prevents fixing the underlying issue.
*
* @sa
* vtkDataArray vtkStringArray vtkCellArray
*/
...
...
This diff is collapsed.
Click to expand it.
Documentation/release/dev/breaking-change-remove-nlohmann-json-from-public-API.md
0 → 100644
+
7
−
0
View file @
27f2fd11
# Remove usage of the nlohmannjson library from public facing API
The
`nlohmann::json vtkAbstractArray::SerializeValues()`
method is now removed
as the public exposure of VTK's vendored
`nlohmannjson`
library caused difficulty for downstream projects that link to a different nlohmannjson.
These methods were added in
[
vtk/vtk!11163
](
https://gitlab.kitware.com/vtk/vtk/-/merge_requests/11163
)
which was released in 9.4. That merge
request has now been reverted. These methods are removed (instead of deprecation) because deprecation would prevent fixing the problem.
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment