On Windows use CreateFile (with FILE_FLAG_BACKUP_SEMANTICS so it works
for directories), GetSystemTimeAsFileTime, and SetFileTime to touch.  On
other platforms prefer utimensat, then utimes, then utime.

Change-Id: Ie85fe3766661803e66f39975a147cd6f7320ea59
CMake-Issue: 14020

Replace use of COMPILE_FLAGS with COMPILE_DEFINITIONS for the
SystemTools.cxx source file property and spell out each definition on
its own line.

Change-Id: I213326b25fc7510107b78a8e233a3198862d9309

Allocate a buffer large enough to hold the input path when removing a
trailing slash.  Use a local stack buffer when it is large enough and
fall back to heap allocation otherwise.

Change-Id: Ibc4b4c96c7b0fafae9f4b5cd7ea894bdd605a098

Change-Id: Ib8b8b5d406e5123ac9c280bb5d2948916f5a997b

.../kwsys/SystemInformation.cxx: In member function ‘int cmsys::SystemInformationImplementation::GetFullyQualifiedDomainName(std::string&)’:
.../kwsys/SystemInformation.cxx:1475:31: warning: conversion to ‘int’ from ‘long unsigned int’ may alter its value [-Wconversion]
         = (fam==AF_INET?sizeof(struct sockaddr_in):sizeof(struct sockaddr_in6));
                               ^
.../kwsys/SystemInformation.cxx:1475:58: warning: conversion to ‘int’ from ‘long unsigned int’ may alter its value [-Wconversion]
         = (fam==AF_INET?sizeof(struct sockaddr_in):sizeof(struct sockaddr_in6));

POSIX says the type of the second argument to getnameinfo() should be
socklen_t so use that as the variable type here. Chances are high that this
has the same size as size_t so the warning would go away.

Change-Id: Ie2816b401a8fe7d615fa17a58b611e2cad14e4ea

This should fix this compiler warning observed with aCC:

Warning 863: ".../kwsys/testSystemInformation.cxx", line 93 # Result of operator << is widened from int to long.
        if (info.DoesCPUSupportFeature(1 << i))

Change-Id: Ie33521c354b11e3e852c801537c0c82f82c7041c

Andreas Mohr authored 11 years ago and Brad King committed 11 years ago

Change-Id: If6fc66bb0800c21a19dd06e41afc1eafa305b24e

Do not strip the trailing slash from root components like "c:/" before
passing to stat().

Suggested-by: Patrick Spendrin <ps_ml@gmx.de>
Change-Id: If8fffd6b1178f0edcd6984a8b865c697dae081c7

Paul Kunysch authored 12 years ago and Brad King committed 12 years ago

The Single UNIX (R) Specification, Version 2 defines "FD_SETSIZE", but
does not specify the effects if it's (re)defined by an application.

Cygwin's newlib headers document that FD_SETSIZE may be defined
by the user [1] and should be >= NOFILE. [2]  Setting it to 16384
uses a value from Cygwin's poll() implementation. [3]

[1]: http://cygwin.com/cgi-bin/cvsweb.cgi/src/newlib/libc/include/sys/types.h?cvsroot=src
[2]: http://cygwin.com/cgi-bin/cvsweb.cgi/src/winsup/cygwin/include/sys/param.h?cvsroot=src
[3]: http://cygwin.com/cgi-bin/cvsweb.cgi/src/winsup/cygwin/poll.cc?cvsroot=src

Change-Id: Idc43fc28a398979da1e9289e1080a9fc1090c605

Sean McBride authored 12 years ago and Brad King committed 12 years ago

Commit 857bda17 (SystemInformation: Report more information, 2012-05-29)
added use of __GNUG__ which is equivalent to __GNUC__ && __cplusplus.
Since this is a C++ source file and we use __GNUC__ elsewhere it is more
consistent and less redundant to use the latter.

Change-Id: I6428e2601310dd35c14ac643dcec199b01977842

Remove the abort() from the internal Getcwd implementation.  All callers
check the return value already.  Fix one caller's "else" behavior to
avoid crashing.

Change-Id: I3450c4942ffa108b2313877c9472820f6b465baa

Sean McBride authored 12 years ago and Brad King committed 12 years ago

Mostly add 'static' to private functions/globals.

Change-Id: Ic7fa75bcc0f245e7b4f8d554db4f58ac0c585e2a

Sean McBride authored 12 years ago and Brad King committed 12 years ago

Change-Id: I248e0cba2c02b1bb1ab9dc4a67712c2b6497ca83

Alan Hourihane authored 12 years ago and Brad King committed 12 years ago

Change-Id: I4e44d61c175e1deb4cecdebfdba5fa05cbdd1e6b

Alan Hourihane authored 12 years ago and Brad King committed 12 years ago

Change-Id: I63c5e599f8d2a66b448356e8920039ddecdd8431

* changes:
  SystemInformation: try using assembler with BorlandC
  SystemInformation: cache result of IsHyperThreadingSupported()
  SystemInformation: make IsHyperThreadingSupported() return bool
  SystemInformation: fix "Multi-character character constant"

* changes:
  SystemInformation: query memory size with sysconf() on Solaris
  SystemInformation: count processors with sysconf() on Solaris
  SystemInformation: factor out QueryProcessorBySysconf()
  SystemInformation: factor out QueryMemoryBySysconf()

Change-Id: Idba42c70b312a524430780471013b0e2dd245529

A positive result of this function is now cached and reused on later
calls.

Change-Id: I4a9048c0a234243e929b4726f9aa4351bcb75558

The manpage suggests this is available since Solaris 2.3, which is from
1993. No need to spawn a process then for this information. As an extra
bonus we get information about the available physical memory for free,
which was missing before. On 32 bit processes we will still fall back
to the old method as the values returned by a 32 bit process on a 64
bit host are limited to 4 GiB.

Rename QuerySolarisInfo() to QuerySolarisProcessor() as that is now what
this function is about.

Change-Id: I76fe77a7d746d92d1752119f2c2703652c575339

Change-Id: Ic964ad79ab256e0ce693764065e92528a255fddc

Borland compiler correctly complains about this:

Warning W8098 SystemInformation.cxx 3773:
   Multi-character character constant in function
   SystemInformationImplementation::IsHyperThreadingSupported()
Warning W8098 SystemInformation.cxx 3775:
   Multi-character character constant in function
   SystemInformationImplementation::IsHyperThreadingSupported()
Warning W8098 SystemInformation.cxx 3777:
   Multi-character character constant in function
   SystemInformationImplementation::IsHyperThreadingSupported()

Change-Id: Id5b5411ed0d04d985dfc8235a6c8c817a4e12ccf

Change-Id: I55506c112cfffdb8d56a85bae0eeaae91d4035bf

Change-Id: I3adc0d179c210e10098b84ac47b9401b1c7b2ecc

Change-Id: Ic2354e8f33b9dd2ceb5fb8cdc16102922ebbe72a

Change-Id: I9ec994e96c895196491dccba7d867cdfe6321a61

Change-Id: I0297d1cdb6010f904c5758b0065173cdc77e4c30

Change-Id: I06ac6ee8806cfcdf9048545f6abb509cd7ef1c73

Change-Id: I840f1a928ac7396bc4ee2a2081e9b68c4f14c1d7

Append the whole process output in one go to our buffer instead of doing
this byte by byte.

Change-Id: I060aac43e59d514e999a9fca897ce5fd76fdddd6

kwsysProcess_WaitForData() may return kwsysProcess_Pipe_Timeout, which
is 255. The current check would take that as sign of success and read
invalid data or even crash.

Change-Id: I148f5d435a088cb3814f513cce4f13e5358e5730

SystemInformation.cxx: In member function 'bool kwsys::SystemInformationImplementation::QueryProcessor()':
SystemInformation.cxx:3029:31: warning: conversion to 'unsigned int' from 'long int' may alter its value [-Wconversion]

Change-Id: I622072bf176d96814a8b17ce66b099cbd797913a

The parent commit removed a useless if condition but forgot to leave
behind the behavior from either path.  Add the missing assignment from
the original else block.

Change-Id: I810cce08eb295ff2ba8c2eeff7631178b49c6725