Kitware Robot authored 6 years ago and Brad King committed 6 years ago

Run the `clang-format.bash` script to update all our C and C++ code to a
new style defined by `.clang-format`.  Use `clang-format` version 6.0.

* If you reached this commit for a line in `git blame`, re-run the blame
  operation starting at the parent of this commit to see older history
  for the content.

* See the parent commit for instructions to rebase a change across this
  style transition commit.

UBsan causes our test crash to abort instead.  Switch the test to
explicitly abort when sanitizers are in use.

Kitware Robot authored 8 years ago and Brad King committed 8 years ago

Run the `clang-format.bash` script to update all our C and C++ code to a new
style defined by `.clang-format`.  Use `clang-format` version 3.8.

* If you reached this commit for a line in `git blame`, re-run the blame
  operation starting at the parent of this commit to see older history
  for the content.

* See the parent commit for instructions to rebase a change across this
  style transition commit.

Change-Id: Ie3aedc03bfe5c3999d4a077fafb8c6f3bbffc5c5

Per-source copyright/license notice headers that spell out copyright holder
names and years are hard to maintain and often out-of-date or plain wrong.
Precise contributor information is already maintained automatically by the
version control tool.  Ultimately it is the receiver of a file who is
responsible for determining its licensing status, and per-source notices are
merely a convenience.  Therefore it is simpler and more accurate for
each source to have a generic notice of the license name and references to
more detailed information on copyright holders and full license terms.

Our `Copyright.txt` file now contains a list of Contributors whose names
appeared source-level copyright notices.  It also references version control
history for more precise information.  Therefore we no longer need to spell
out the list of Contributors in each source file notice.

Replace KWSys per-source copyright/license notice headers with a short
description of the license and links to `Copyright.txt` and online
information available from "https://cmake.org/licensing#kwsys".

Run the `filter-notices.bash` script to perform the replacements mechanically.
Manually fix up the shebang line in one file.

Change-Id: I8497f7c868664dcf54a8608ab302ad93c860b334

The clang-format tool sorts `#include` lines within contiguous blocks.
Separate blocks with blank lines and sort the include lines within them
so that clang-format does not re-order anything.

Change-Id: I96d6828f470b9a234464972172d46afab322487c

James Johnston authored 9 years ago and Brad King committed 9 years ago

Teach testProcess-1 to stress-test kwsysProcess for leaks that lead to
failure by running the test many times.

Change-Id: I1906b935f4096161f30f418918653087f91dde16

Store and pass the interruptDelay parameter as 'unsigned int' so
it does not have to be converted to pass to testProcess_sleep.
Otherwise some compilers warn about the signed->unsigned conversion.

Change-Id: I1edf6dbc852231834a5de82c5b14f84ac8018c1f

James Johnston authored 9 years ago and Brad King committed 9 years ago

Two new tests were added to testProcess:
 * Test 9 is constructed of the root test process, a child process,
   and a grandchild process.  The grandchild ignores all Ctrl+C signals
   and then sleeps.  The child runs the grandchild normally.  The root
   process runs the child in a new process group, sends it a Ctrl+C
   signal, and then lets the process expire to prove that the child was
   blocked waiting for the uninterruptable grandchild to die.
 * Test 10 is constructed of the root test process, a child process,
   and a grandchild process.  The grandchild sleeps and processes
   signals normally.  The child runs the grandchild in a new process
   group.  The root process runs the child in a new process group as
   well, sends it a Ctrl+C, and then verifies that: (1) the child does
   indeed terminate with an interrupt signal, (2) the child did not
   expire, proving that it retransmitted the signal to the sleeping
   grandchild before waiting for the grandchild to terminate.

Change-Id: Iba5bee546a82eb61a41d4194341e9382a00279d4

James Johnston authored 9 years ago and Brad King committed 9 years ago

Code for delaying/sleeping has been unified into one location.

Change-Id: I234f3e1be667539e8126f7ed24aec95fe14284b3

In ProcessUNIX.c, testProcess.c, and testCommandLineArguments1.cxx, add
assert() calls to tell Clang scan-build that we do not expect certain
pointers to be NULL.

Change-Id: I4a2b035cf58198606b4698c9d0e2048a66f15fd0

Clinton Stimpson authored 10 years ago and Brad King committed 10 years ago

Change-Id: I23a27b25bf7a2f8f8785c575e1e595f785f9db98

Sean McBride authored 12 years ago and Brad King committed 12 years ago

Mostly add 'static' to private functions/globals.

Change-Id: Ic7fa75bcc0f245e7b4f8d554db4f58ac0c585e2a

Change-Id: I881521d84a31b6b1c68930f94acbcea88b5c1dea

Sean McBride authored 12 years ago and Brad King committed 12 years ago

Some compilers, notably Clang, will warn at compile time (or
runtime with debug flags) if they detect a null dereference.
Try to outsmart them by dereferencing an address a little
larger than NULL.

Change-Id: I53c6512f814ad3e8977c076904f0415e8aaaaea5

Clang is smart enough to recognize that "*(int*)0=0" invokes undefined
behavior, warns, and produces an "undefined instruction".  The message
in commit "Avoid Clang optimizer bug in testProcess-[45]" (2010-07-02)
is incorrect; this is not a Clang bug.  It really is undefined
behavior.  Use "*(int*)1=0" to produce a crash instead.

Clang's optimizer, as of clang version 2.8 (trunk 107463), produces the
undefined instruction 'ud2' for the code "*(int*)0=0" on OS X x86_64.
It causes our crash tests to fail because the child process exits with
an invalid instruction instead of a segmentation fault.  Work around the
bug by using "*(int*)1=0" in this case.

Fix warnings in CMake source code. Suppress warnings in Lexer and Parser files that are 'too hard' to fix.

This converts the KWSys license to a pure 3-clause OSI-approved BSD
License.  We drop the previous license clause requiring modified
versions to be plainly marked.  We also update the KWSys copyright to
cover the full development time range.

The test is supposed to terminate quickly when its child crashes, but
that seems to take over 10s on busy systems.  This extends the test's
timeout to 30s to help it pass when running on a busy system.

ENH: Changes based on patch from Ryan C. Gordon to enable process execution on BeOS.  There seems to be no way to implement it without polling (or threads).

ENH: Extended test 0 to run the executable twice using the same process object.  This tests the reusability of the objects.

BUG: Use sleep(1) instead of usleep(1000000) because some UNIX systems specify that the argument to usleep must be less than 1000000.

ENH: Disabling test 6 on QNX until process killing can be resolved.  It will just fail always for now.

BUG: Extending timeout of test 6 from 0.1 seconds to 3 seconds.  This should avoid missed signals and intermittent failures.

BUG: Drastically extending test5's timeouts to get it to pass when running on a heavily-loaded machine.